From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41201 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5OMe-0003db-DZ for qemu-devel@nongnu.org; Thu, 31 Mar 2011 16:21:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5OMb-0007lt-1X for qemu-devel@nongnu.org; Thu, 31 Mar 2011 16:21:08 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:44821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5OMa-0007le-SL for qemu-devel@nongnu.org; Thu, 31 Mar 2011 16:21:04 -0400 Received: by ywl41 with SMTP id 41so1321966ywl.4 for ; Thu, 31 Mar 2011 13:21:04 -0700 (PDT) Message-ID: <4D94E22E.4000205@codemonkey.ws> Date: Thu, 31 Mar 2011 15:21:02 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH RFC] vga: flag vga ram for notifiers References: <20110331174328.GA25133@redhat.com> <4D94C916.6080709@codemonkey.ws> <20110331184940.GA25688@redhat.com> <4D94CFA0.3030605@codemonkey.ws> <20110331190750.GA25914@redhat.com> <4D94D583.7050203@codemonkey.ws> <20110331200300.GA26170@redhat.com> In-Reply-To: <20110331200300.GA26170@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Alex Williamson , qemu-devel@nongnu.org On 03/31/2011 03:03 PM, Michael S. Tsirkin wrote: > On Thu, Mar 31, 2011 at 02:26:59PM -0500, Anthony Liguori wrote: >> On 03/31/2011 02:07 PM, Michael S. Tsirkin wrote: >>>> Just needs some love. >>>> >>>> VGA is just another device. It happens to be that we treat VGA >>>> device memory as something that behaves like ram occassionally but >>>> that does not make it RAM. >>> If we agree on that, will a pair of functions for this work? >>> How about device_register_ram / device_unregister_ram ? >> To register normal RAM or to register stuff that isn't RAM but looks >> and tastes like RAM? > The later. If you're going to take that approach (and I'd strongly advise you to reconsider :-)), I'd at least suggest making the name a bit clearer. For instance, device_shadow_memory_as_ram() or something along those lines. Regards, Anthony Liguori >>>> Something like vhost doesn't need to see anything but RAM. If we >>>> have a mechanism to identify RAM as RAM, then vhost can only look at >>>> RAM memory and not worry about things like VGA. >>>> >>>> I thought Alex had gotten a mini-version of RamAPI in but I can't >>>> seem to figure out what that included. >>> Me neither. >>> >>>> At any rate, the point is >>>> still that registering things that you want to exclude in vhost is >>>> the wrong approach, you want to explicitly mark the things you want >>>> to include. >>>> >>>> Regards, >>>> >>>> Anthony Liguori >>> vhost just wants RAM. >> Right, so mark RAM, and call it a day :-) >> >> Regards, >> >> Anthony Liguori >>