From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35835 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5YG8-00023W-Bp for qemu-devel@nongnu.org; Fri, 01 Apr 2011 02:55:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5YG6-0007Xd-HX for qemu-devel@nongnu.org; Fri, 01 Apr 2011 02:55:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5YG6-0007XM-4w for qemu-devel@nongnu.org; Fri, 01 Apr 2011 02:55:02 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p316t0oM021066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 1 Apr 2011 02:55:00 -0400 Message-ID: <4D9576AA.1040803@redhat.com> Date: Fri, 01 Apr 2011 08:54:34 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1301638940-22372-1-git-send-email-jasowang@redhat.com> In-Reply-To: <1301638940-22372-1-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH V3] floppy: save and restore DIR register List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com On 04/01/11 08:22, Jason Wang wrote: > We need to keep DIR register unchanged across migration, but currently it > depends on the media_changed flags from block layer. Since we do not > save/restore it and the bdrv_open() called in dest node may set the > media_changed flag when trying to open floppy image, guest driver may think the > floppy have changed after migration. To fix this, a new filed media_changed in > FDrive strcutre was introduced in order to save and restore the it from block > layer through pre_save/post_load callbacks. > > Signed-off-by: Jason Wang Looked through this, and it looks perfectly reasonable to me. Reviewed-by: Jes Sorensen