From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39210 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5ebY-0000zm-4r for qemu-devel@nongnu.org; Fri, 01 Apr 2011 09:41:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5ebW-0007ng-H0 for qemu-devel@nongnu.org; Fri, 01 Apr 2011 09:41:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5ebW-0007mv-87 for qemu-devel@nongnu.org; Fri, 01 Apr 2011 09:41:34 -0400 Message-ID: <4D95D5F2.5050101@redhat.com> Date: Fri, 01 Apr 2011 15:41:06 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing support References: <1301487385-1755-1-git-send-email-Jes.Sorensen@redhat.com> <4D9459B8.8000901@redhat.com> <4D946250.5010406@redhat.com> <4D9467CA.9020306@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On 03/31/11 13:49, Stefan Hajnoczi wrote: > On Thu, Mar 31, 2011 at 12:38 PM, Kevin Wolf wrote: >> Am 31.03.2011 13:15, schrieb Jes Sorensen: >>> On 03/31/11 12:38, Kevin Wolf wrote: >>> I have been a little reluctant to do this because it will break the ABI >>> for tools running qemu-img from a GUI etc. >> >> That's the reason for the "from a terminal" part. If we check for >> isatty(), we should handle these cases just fine. > > Yes, I think checking for a tty is enough precaution and allows users > to get the benefit of the progress bar. TBH I'd probably forget to > add -p half the time :). Ok, this is fine with me - however how do you suggest we offer the option to disable it on the command line, an additional flag? Jes