From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail
Date: Fri, 01 Apr 2011 12:24:16 -0500 [thread overview]
Message-ID: <4D960A40.6040600@linux.vnet.ibm.com> (raw)
In-Reply-To: <AANLkTi=MEGq2LXZ1T7jN48N32Zb0e_xUMAMF4u4619Xt@mail.gmail.com>
On 04/01/2011 11:58 AM, Peter Maydell wrote:
> On 1 April 2011 17:55, Michael Roth<mdroth@linux.vnet.ibm.com> wrote:
>> But there *are* some warnings that make sense to complain about without
>> saying "you can't do this", like extern's in .c files: some cases are
>> exceptional.
>
> I'd treat everything checkpatch says as a warning anyway, because it gets
> confused by things like macros often enough that you can't guarantee
> that everything it thinks is an error is truly an error.
Well, we always have the option of ignoring the return code and just
looking at the output. Would be nice to be able to automate the check
somewhat reliably though, and just override the false positives when
they pop up.
>
> -- PMM
next prev parent reply other threads:[~2011-04-01 17:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 15:20 [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail Michael Roth
2011-04-01 15:20 ` [Qemu-devel] [PATCH 1/2] checkpatch.pl: add --no-fail-on-warn option Michael Roth
2011-04-01 15:20 ` [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error Michael Roth
2011-04-01 15:33 ` [Qemu-devel] " Michael Roth
2011-04-01 15:49 ` [Qemu-devel] " Stefan Hajnoczi
2011-04-01 18:46 ` Blue Swirl
2011-04-02 14:02 ` Stefan Hajnoczi
2011-04-01 15:52 ` [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail Peter Maydell
2011-04-01 15:59 ` Stefan Hajnoczi
2011-04-01 16:16 ` Peter Maydell
2011-04-01 16:55 ` Michael Roth
2011-04-01 16:58 ` Peter Maydell
2011-04-01 17:24 ` Michael Roth [this message]
2011-04-01 17:01 ` Stefan Hajnoczi
2011-04-01 17:25 ` Michael Roth
2011-04-02 13:48 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D960A40.6040600@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).