From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37462 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q5i58-0003V6-Ab
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 13:24:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Q5i57-0008Jz-1l
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 13:24:21 -0400
Received: from e8.ny.us.ibm.com ([32.97.182.138]:41067)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Q5i56-0008Jq-Vi
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 13:24:21 -0400
Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56])
	by e8.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p31GxQ2c002502
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 12:59:26 -0400
Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 28D4238C803C
	for <qemu-devel@nongnu.org>; Fri,  1 Apr 2011 13:24:12 -0400 (EDT)
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p31HOJXu278182
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 13:24:19 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p31HOIPn028558
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 13:24:18 -0400
Message-ID: <4D960A40.6040600@linux.vnet.ibm.com>
Date: Fri, 01 Apr 2011 12:24:16 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail
References: <1301671255-27717-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<AANLkTi=+XcYfjGdvh_VxEomJMX3zSoYUZx9-wPtpVE0c@mail.gmail.com>
	<AANLkTik2sBYGEVv6N4ZeATFK8qNZjAOXeBJVQaoya6ZX@mail.gmail.com>
	<AANLkTi=_MKeak8yy+GFLjdLd4mV9vbkDKQ2BEA-GEBr1@mail.gmail.com>
	<4D96038B.3020703@linux.vnet.ibm.com>
	<AANLkTi=MEGq2LXZ1T7jN48N32Zb0e_xUMAMF4u4619Xt@mail.gmail.com>
In-Reply-To: <AANLkTi=MEGq2LXZ1T7jN48N32Zb0e_xUMAMF4u4619Xt@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On 04/01/2011 11:58 AM, Peter Maydell wrote:
> On 1 April 2011 17:55, Michael Roth<mdroth@linux.vnet.ibm.com>  wrote:
>> But there *are* some warnings that make sense to complain about without
>> saying "you can't do this", like extern's in .c files: some cases are
>> exceptional.
>
> I'd treat everything checkpatch says as a warning anyway, because it gets
> confused by things like macros often enough that you can't guarantee
> that everything it thinks is an error is truly an error.

Well, we always have the option of ignoring the return code and just 
looking at the output. Would be nice to be able to automate the check 
somewhat reliably though, and just override the false positives when 
they pop up.

>
> -- PMM