From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37932 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q5i6K-00045w-Tn
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 13:25:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Q5i6D-000082-9Q
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 13:25:29 -0400
Received: from e5.ny.us.ibm.com ([32.97.182.145]:33612)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Q5i6D-00007w-1M
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 13:25:29 -0400
Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85])
	by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p31GxsYk016193
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 12:59:54 -0400
Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235])
	by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 7BFD56E8036
	for <qemu-devel@nongnu.org>; Fri,  1 Apr 2011 13:25:28 -0400 (EDT)
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p31HPSkR275862
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 13:25:28 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p31HPM4U001185
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 13:25:28 -0400
Message-ID: <4D960A7E.5060503@linux.vnet.ibm.com>
Date: Fri, 01 Apr 2011 12:25:18 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail
References: <1301671255-27717-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<AANLkTi=+XcYfjGdvh_VxEomJMX3zSoYUZx9-wPtpVE0c@mail.gmail.com>
	<AANLkTik2sBYGEVv6N4ZeATFK8qNZjAOXeBJVQaoya6ZX@mail.gmail.com>
	<AANLkTi=_MKeak8yy+GFLjdLd4mV9vbkDKQ2BEA-GEBr1@mail.gmail.com>
	<4D96038B.3020703@linux.vnet.ibm.com>
	<20110401170151.GA15214@stefanha-thinkpad.localdomain>
In-Reply-To: <20110401170151.GA15214@stefanha-thinkpad.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>

On 04/01/2011 12:01 PM, Stefan Hajnoczi wrote:
> On Fri, Apr 01, 2011 at 11:55:39AM -0500, Michael Roth wrote:
>> I'd prefer to only document "strict" guidelines, and treat
>> checkpatch.pl warnings ("suggestions") as an extra "reward" you get
>> for taking the time to run it.
>
> I don't want to be punished for running checkpatch.pl like I'm supposed
> to while those who don't can get away with more.

You're not! These are extra morsels of goodness :)

>
> A --pedantic mode would be fine although probably no one besides the
> author would use it :).

True :) But you're right, this is probably the better approach. How bout:

--warnings: print coding style warnings in addition to errors, and exit 
failure if encountered

Then default to suppressing warning statements, and --no-fail-on-warn 
behavior.

>
> The stuff that gets reported by the default invocation needs to matter,
> otherwise checkpatch.pl isn't useful and people will bypass it.
>
> Stefan