From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46835 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6jXD-000415-Jt
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 09:09:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q6jXB-0003xq-PE
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 09:09:34 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:51507)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q6jXB-0003xk-Lc
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 09:09:33 -0400
Received: by gwb19 with SMTP id 19so2654402gwb.4
	for <qemu-devel@nongnu.org>; Mon, 04 Apr 2011 06:09:33 -0700 (PDT)
Message-ID: <4D99C309.6060905@codemonkey.ws>
Date: Mon, 04 Apr 2011 08:09:29 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command
References: <4D74A8C9.2020408@cn.fujitsu.com>	<4D74A974.6090509@cn.fujitsu.com>
	<20110404105949.GA30324@redhat.com>
	<m3r59i439t.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3r59i439t.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Lai Jiangshan <eag0628@gmail.com>, Lai Jiangshan <laijs@cn.fujitsu.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Avi Kivity <avi@redhat.com>

On 04/04/2011 07:19 AM, Markus Armbruster wrote:
> [Note cc: Anthony]
>
> "Daniel P. Berrange"<berrange@redhat.com>  writes:
>
>> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote:
>>> From: Lai Jiangshan<laijs@cn.fujitsu.com>
>>> Date: Mon, 7 Mar 2011 17:05:15 +0800
>>> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command
>>>
>>> inject-nmi command injects an NMI on all CPUs of guest.
>>> It is only supported for x86 guest currently, it will
>>> returns "Unsupported" error for non-x86 guest.
>>>
>>> ---
>>>   hmp-commands.hx |    2 +-
>>>   monitor.c       |   18 +++++++++++++++++-
>>>   qmp-commands.hx |   29 +++++++++++++++++++++++++++++
>>>   3 files changed, 47 insertions(+), 2 deletions(-)
>> Does anyone have any feedback on this addition, or are all new
>> QMP patch proposals blocked pending Anthony's QAPI work ?
> That would be bad.  Anthony, what's holding this back?

It doesn't pass checkpath.pl.

But I'd also expect this to come through Luiz's QMP tree.

Regards,

Anthony Liguori