From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59030 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6jk4-0000mB-6Q for qemu-devel@nongnu.org; Mon, 04 Apr 2011 09:22:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6jk2-0008DF-Eu for qemu-devel@nongnu.org; Mon, 04 Apr 2011 09:22:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6jk2-0008Cw-40 for qemu-devel@nongnu.org; Mon, 04 Apr 2011 09:22:50 -0400 Message-ID: <4D99C61E.3080600@redhat.com> Date: Mon, 04 Apr 2011 16:22:38 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change References: <1301425482-8722-1-git-send-email-stefanha@linux.vnet.ibm.com> <1301425482-8722-4-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi , Juan Quintela , libvir-list@redhat.com, qemu-devel@nongnu.org, Ryan Harper , Amit Shah On 04/03/2011 02:57 PM, Stefan Hajnoczi wrote: > In order for media change to work with Linux host CD-ROM it is > necessary to reopen the file (otherwise the inode size will not > refresh, this is an issue with existing kernels). > Maybe we should fix the bug in Linux (and backport as necessary)? I think cd-rom assignment is sufficiently obscure that we can require a fixed kernel instead of providing a workaround. -- error compiling committee.c: too many arguments to function