From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38091 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6l4h-0004C4-AM for qemu-devel@nongnu.org; Mon, 04 Apr 2011 10:48:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6l48-0006QF-VG for qemu-devel@nongnu.org; Mon, 04 Apr 2011 10:47:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38305 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6l48-0006Py-Q6 for qemu-devel@nongnu.org; Mon, 04 Apr 2011 10:47:40 -0400 Message-ID: <4D99DA0B.2020209@suse.de> Date: Mon, 04 Apr 2011 16:47:39 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Aurelien Jarno On 04/04/2011 01:09 PM, Peter Maydell wrote: > CPU_QuadU isn't used on all targets, but there's no harm in defining the > typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because > softfloat-native doesn't have a float128 type. This avoids the need for > every new target which uses CPU_QuadU to add itself to an #ifdef in > what ought to be target-agnostic code. > > Signed-off-by: Peter Maydell I don't really know my way around FP, but from here it looks good :). Not sure about the arm part, but I trust Peter on that one ;). Alex