From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V1 2/8] Provide ACPI SSDT table for TPM device + S3 resume support
Date: Mon, 04 Apr 2011 10:52:44 -0400 [thread overview]
Message-ID: <4D99DB3C.1020104@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110404041740.GB13528@morn.localdomain>
On 04/04/2011 12:17 AM, Kevin O'Connor wrote:
> On Wed, Mar 30, 2011 at 01:55:36PM -0400, Stefan Berger wrote:
>> This patch provides ACPI support for the TPM device. It probes for the TPM
>> device and only if a TPM device is found then the TPM's SSDT and TCPA table
>> are created. This patch also connects them to the RSDT.
> [...]
>> // Space to reserve in high-memory for tables
>> -#define CONFIG_MAX_HIGHTABLE (64*1024)
>> +#if CONFIG_TCGBIOS
>> +# define CONFIG_MAX_HIGHTABLE (96*1024)
>> +#else
>> +# define CONFIG_MAX_HIGHTABLE (64*1024)
>> +#endif
> I'm a bit confused on patch ordering - it seems CONFIG_TCGBIOS is
> defined in patch 4 but used in patch 2.
I had it in patch 2 since there I am allocating 64kb in the high memory...
I'll move it to patch 4.
> Also, I'd prefer to avoid ifdefs - just up the size to 96 always, or
> do something like:
>
> #define CONFIG_MAX_HIGHTABLE ((64*1024) + CONFIG_TCGBIOS*(32*1024))
>
Done that.
Stefan
> -Kevin
next prev parent reply other threads:[~2011-04-04 14:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 17:55 [Qemu-devel] [PATCH V1 0/8] Add TPM support to SeaBIOS Stefan Berger
2011-03-30 17:55 ` [Qemu-devel] [PATCH V1 1/8] Add an implementation for a TPM TIS driver Stefan Berger
2011-03-30 17:55 ` [Qemu-devel] [PATCH V1 2/8] Provide ACPI SSDT table for TPM device + S3 resume support Stefan Berger
2011-04-04 4:17 ` Kevin O'Connor
2011-04-04 14:52 ` Stefan Berger [this message]
2011-03-30 17:55 ` [Qemu-devel] [PATCH V1 3/8] Implementation of the TCG BIOS extensions Stefan Berger
2011-04-04 4:14 ` Kevin O'Connor
2011-04-04 14:49 ` Stefan Berger
2011-03-30 17:55 ` [Qemu-devel] [PATCH V1 4/8] Build the TCG BIOS extensions and TPM drivers Stefan Berger
2011-03-30 17:55 ` [Qemu-devel] [PATCH V1 5/8] Support for BIOS interrupt handler Stefan Berger
2011-04-04 4:30 ` Kevin O'Connor
2011-04-04 14:54 ` Stefan Berger
2011-03-30 17:55 ` [Qemu-devel] [PATCH V1 6/8] Add measurement code to the BIOS Stefan Berger
2011-04-04 4:57 ` Kevin O'Connor
2011-04-04 16:38 ` Stefan Berger
2011-03-30 17:55 ` [Qemu-devel] [PATCH V1 7/8] Add a menu for TPM control Stefan Berger
2011-03-30 17:55 ` [Qemu-devel] [PATCH V1 8/8] Optional tests for the TIS interface Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D99DB3C.1020104@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).