From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39002 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6lBY-0005oJ-A4 for qemu-devel@nongnu.org; Mon, 04 Apr 2011 10:55:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6l95-0007Z4-Bd for qemu-devel@nongnu.org; Mon, 04 Apr 2011 10:52:48 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:43828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6l95-0007Yi-6I for qemu-devel@nongnu.org; Mon, 04 Apr 2011 10:52:47 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e39.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p34EdXuH014026 for ; Mon, 4 Apr 2011 08:39:33 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p34Eqj2H116180 for ; Mon, 4 Apr 2011 08:52:45 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p34EqjBS023440 for ; Mon, 4 Apr 2011 08:52:45 -0600 Message-ID: <4D99DB3C.1020104@linux.vnet.ibm.com> Date: Mon, 04 Apr 2011 10:52:44 -0400 From: Stefan Berger MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V1 2/8] Provide ACPI SSDT table for TPM device + S3 resume support References: <20110330175534.302129463@linux.vnet.ibm.com> <20110330175558.493257530@linux.vnet.ibm.com> <20110404041740.GB13528@morn.localdomain> In-Reply-To: <20110404041740.GB13528@morn.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: seabios@seabios.org, qemu-devel@nongnu.org On 04/04/2011 12:17 AM, Kevin O'Connor wrote: > On Wed, Mar 30, 2011 at 01:55:36PM -0400, Stefan Berger wrote: >> This patch provides ACPI support for the TPM device. It probes for the TPM >> device and only if a TPM device is found then the TPM's SSDT and TCPA table >> are created. This patch also connects them to the RSDT. > [...] >> // Space to reserve in high-memory for tables >> -#define CONFIG_MAX_HIGHTABLE (64*1024) >> +#if CONFIG_TCGBIOS >> +# define CONFIG_MAX_HIGHTABLE (96*1024) >> +#else >> +# define CONFIG_MAX_HIGHTABLE (64*1024) >> +#endif > I'm a bit confused on patch ordering - it seems CONFIG_TCGBIOS is > defined in patch 4 but used in patch 2. I had it in patch 2 since there I am allocating 64kb in the high memory... I'll move it to patch 4. > Also, I'd prefer to avoid ifdefs - just up the size to 96 always, or > do something like: > > #define CONFIG_MAX_HIGHTABLE ((64*1024) + CONFIG_TCGBIOS*(32*1024)) > Done that. Stefan > -Kevin