From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51934 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6lX3-0000lx-5d
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 11:17:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Q6lJk-0003LU-7X
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 11:03:53 -0400
Received: from cantor2.suse.de ([195.135.220.15]:39043 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Q6lJk-0003Ky-06
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 11:03:48 -0400
Message-ID: <4D99DDD0.5070107@suse.de>
Date: Mon, 04 Apr 2011 17:03:44 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1301847684-8125-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1301847684-8125-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] spapr_vscsi: Set uninitialized variable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, David Gibson <dwg@au1.ibm.com>

On 04/03/2011 06:21 PM, Stefan Weil wrote:
> cppcheck reports this error:
>
> hw/spapr_vscsi.c:274: error: Uninitialized variable: rc
>
> If llen == 0, rc was indeed used without being initialized.
>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
> ---
>   hw/spapr_vscsi.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/spapr_vscsi.c b/hw/spapr_vscsi.c
> index e142dae..9928334 100644
> --- a/hw/spapr_vscsi.c
> +++ b/hw/spapr_vscsi.c
> @@ -255,7 +255,7 @@ static int vscsi_srp_direct_data(VSCSIState *s, vscsi_req *req,
>   {
>       struct srp_direct_buf *md = req->cur_desc;
>       uint32_t llen;
> -    int rc;
> +    int rc = 0;

David, is this correct? Or would rc be -1 when !llen?


Alex