From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53062 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6mDu-0007fs-Lx
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 12:01:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Q6mDt-0002bm-GA
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 12:01:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56310)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Q6mDt-0002bh-5N
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 12:01:49 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p34G1mu4014591
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 4 Apr 2011 12:01:48 -0400
Message-ID: <4D99EB68.7050601@redhat.com>
Date: Mon, 04 Apr 2011 19:01:44 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1301930887-20705-1-git-send-email-avi@redhat.com>
	<20110404155917.GA13423@redhat.com>
In-Reply-To: <20110404155917.GA13423@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 04/04/2011 06:59 PM, Michael S. Tsirkin wrote:
> On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote:
> >  Many PCI BARs that use the memory address space map a single MMIO region into
> >  the entire BAR range.  Introduce an API pci_register_bar_simple() for that use
> >  case, and convert all users where this can be done trivially.
> >
> >  This will reduce the work required to introduce a PCI memory API; it's also
> >  a nice code reduction in its own right.
>
> This will save some code, so
> Acked-by: Michael S. Tsirkin<mst@redhat.com>
>
> I really hope the rest of devices will follow.

Do you see more devices which can be converted to this API?  AFAICT, the 
others will need something more complicated.

-- 
error compiling committee.c: too many arguments to function