From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45288 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6mkW-0002xd-3S
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 12:35:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Q6mkU-0001rQ-RO
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 12:35:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16638)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Q6mkU-0001rL-Is
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 12:35:30 -0400
Message-ID: <4D99F34D.3060804@redhat.com>
Date: Mon, 04 Apr 2011 19:35:25 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple
References: <1301930887-20705-1-git-send-email-avi@redhat.com>
	<20110404155917.GA13423@redhat.com>
	<4D99F061.1090208@codemonkey.ws>
In-Reply-To: <4D99F061.1090208@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On 04/04/2011 07:22 PM, Anthony Liguori wrote:
> On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote:
>> On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote:
>>> Many PCI BARs that use the memory address space map a single MMIO 
>>> region into
>>> the entire BAR range.  Introduce an API pci_register_bar_simple() 
>>> for that use
>>> case, and convert all users where this can be done trivially.
>>>
>>> This will reduce the work required to introduce a PCI memory API; 
>>> it's also
>>> a nice code reduction in its own right.
>> This will save some code, so
>> Acked-by: Michael S. Tsirkin<mst@redhat.com>
>>
>> I really hope the rest of devices will follow.
>
> How complete is this?

I converted all devices which were easy to convert.  There may be one or 
two more that can be converted with additional work (and perhaps with an 
additional pic_bar_get_current_address() API, and a 
pci_bar_set_coalescing() API).  The rest likely need to stick with the 
callback-based API.

-- 
error compiling committee.c: too many arguments to function