From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52420 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6nz8-0003C1-PF
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 13:54:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dsahern@gmail.com>) id 1Q6nz3-00051k-9O
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 13:54:42 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:48205)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dsahern@gmail.com>) id 1Q6nz3-00051V-3t
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 13:54:37 -0400
Received: by pwj6 with SMTP id 6so1869705pwj.4
	for <qemu-devel@nongnu.org>; Mon, 04 Apr 2011 10:54:35 -0700 (PDT)
Message-ID: <4D9A05D1.1000501@gmail.com>
Date: Mon, 04 Apr 2011 11:54:25 -0600
From: David Ahern <dsahern@gmail.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after
	media change
References: <1301425482-8722-1-git-send-email-stefanha@linux.vnet.ibm.com>	<1301425482-8722-4-git-send-email-stefanha@linux.vnet.ibm.com>	<BANLkTik1LNYoJ6O2C+bPM80LBx8bGnr+uw@mail.gmail.com>	<4D99C61E.3080600@redhat.com>
	<4D99C9ED.3020602@codemonkey.ws>
In-Reply-To: <4D99C9ED.3020602@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Juan Quintela <quintela@redhat.com>, libvir-list@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Ryan Harper <ryanh@us.ibm.com>, Avi Kivity <avi@redhat.com>, Amit Shah <amit.shah@redhat.com>



On 04/04/11 07:38, Anthony Liguori wrote:
> On 04/04/2011 08:22 AM, Avi Kivity wrote:
>> On 04/03/2011 02:57 PM, Stefan Hajnoczi wrote:
>>> In order for media change to work with Linux host CD-ROM it is
>>> necessary to reopen the file (otherwise the inode size will not
>>> refresh, this is an issue with existing kernels).
>>>
>>
>> Maybe we should fix the bug in Linux (and backport as necessary)?
>>
>> I think cd-rom assignment is sufficiently obscure that we can require
>> a fixed kernel instead of providing a workaround.
> 
> Do reads fail after CD change?  Or do they succeed and the size is just
> reported incorrectly?
> 
> If it's the later, I'd agree that it needs fixing in the kernel.  If
> it's the former, I'd say it's clearly a feature.

In January 2010 I was seeing old data -- data from the prior CD -- in
the guest after the media change.

David