Re: [Qemu-devel] [PATCH V2 4/9] Add tpm_tis driver to build process

[Stefan Berger <stefanb@linux.vnet.ibm.com>]

On 04/03/2011 05:20 AM, Blue Swirl wrote:
> On Fri, Apr 1, 2011 at 10:57 PM, Stefan Berger
> <stefanb@linux.vnet.ibm.com>  wrote:
>> On 04/01/2011 02:14 PM, Blue Swirl wrote:
>>
>> At this point there is no compile test needed since all code is 'there'.
>> It's merely adding the front-end,i.e., the TPM TIS emulation to be compiled.
> If the basic device (without the tpms-devel library) can be built on
> any OS, the flag should go to default-configs/*86*-softmmu.mak.
>
It can be built on any OS, but it is of no use since the backend 
(libtpms) is only available on Linux and we don't support it on another 
OS. Unless someone else wants to port it to other OSes, I'd say that the 
test for Linux is useful.
I'd actually also only compile the TIS if libtpms could be found, and 
terminate with an error message otherwise. I would add this restriction 
only in the last patch, so that in patch 4 at least for now the TIS can 
be built. Does that sound reasonable?

>> The (libtpms-based) backend is then added later in patch [9/9]. There you
>> then find this here:
>>
>>    if test "$has_tpm" = "1"; then
>> +      if test -r /usr/include/libtpms/tpm_library.h ; then
> Here you make assumptions on the header file location, but it could be
> in /usr/local,  /opt or somewhere where the cross compiler happens to
> find it. Please just do the compile test.
>
Fixed that.

    Stefan