From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46560 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6vhO-0007dc-Ma for qemu-devel@nongnu.org; Mon, 04 Apr 2011 22:08:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6vhN-0001uM-G4 for qemu-devel@nongnu.org; Mon, 04 Apr 2011 22:08:54 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:36937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6vhN-0001u5-As for qemu-devel@nongnu.org; Mon, 04 Apr 2011 22:08:53 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p3526A2H004007 for ; Mon, 4 Apr 2011 20:06:10 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p3528pGA088532 for ; Mon, 4 Apr 2011 20:08:51 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p3528pYY012303 for ; Mon, 4 Apr 2011 20:08:51 -0600 Message-ID: <4D9A79B2.2010502@linux.vnet.ibm.com> Date: Mon, 04 Apr 2011 22:08:50 -0400 From: Stefan Berger MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V2 4/9] Add tpm_tis driver to build process References: <20110330194211.732385449@linux.vnet.ibm.com> <20110330194237.138721858@linux.vnet.ibm.com> <4D962E1C.2000203@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 04/03/2011 05:20 AM, Blue Swirl wrote: > On Fri, Apr 1, 2011 at 10:57 PM, Stefan Berger > wrote: >> On 04/01/2011 02:14 PM, Blue Swirl wrote: >> >> At this point there is no compile test needed since all code is 'there'. >> It's merely adding the front-end,i.e., the TPM TIS emulation to be compiled. > If the basic device (without the tpms-devel library) can be built on > any OS, the flag should go to default-configs/*86*-softmmu.mak. > It can be built on any OS, but it is of no use since the backend (libtpms) is only available on Linux and we don't support it on another OS. Unless someone else wants to port it to other OSes, I'd say that the test for Linux is useful. I'd actually also only compile the TIS if libtpms could be found, and terminate with an error message otherwise. I would add this restriction only in the last patch, so that in patch 4 at least for now the TIS can be built. Does that sound reasonable? >> The (libtpms-based) backend is then added later in patch [9/9]. There you >> then find this here: >> >> if test "$has_tpm" = "1"; then >> + if test -r /usr/include/libtpms/tpm_library.h ; then > Here you make assumptions on the header file location, but it could be > in /usr/local, /opt or somewhere where the cross compiler happens to > find it. Please just do the compile test. > Fixed that. Stefan