From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47580 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6yyO-0004fw-Ow
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 01:38:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1Q6yyN-0002Kt-N5
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 01:38:40 -0400
Received: from e6.ny.us.ibm.com ([32.97.182.146]:40529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1Q6yyN-0002Kk-Km
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 01:38:39 -0400
Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85])
	by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p355EK5F013505
	for <qemu-devel@nongnu.org>; Tue, 5 Apr 2011 01:14:20 -0400
Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235])
	by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 230516E8036
	for <qemu-devel@nongnu.org>; Tue,  5 Apr 2011 01:38:36 -0400 (EDT)
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p355caPY345548
	for <qemu-devel@nongnu.org>; Tue, 5 Apr 2011 01:38:36 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p355cZte028140
	for <qemu-devel@nongnu.org>; Tue, 5 Apr 2011 01:38:35 -0400
Message-ID: <4D9AAADB.6000107@linux.vnet.ibm.com>
Date: Tue, 05 Apr 2011 01:38:35 -0400
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20110405012939.098839448@linux.vnet.ibm.com>
	<20110405051719.GA1500@morn.localdomain>
In-Reply-To: <20110405051719.GA1500@morn.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH V2 0/8] Add TPM support to SeaBIOS
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: seabios@seabios.org, qemu-devel@nongnu.org

On 04/05/2011 01:17 AM, Kevin O'Connor wrote:
> On Mon, Apr 04, 2011 at 09:29:39PM -0400, Stefan Berger wrote:
>> The following set of patches add TPM and Trusted Computing support to SeaBIOS.
>> In particular the patches add:
> Thanks Stefan.
>
> In general, it looks okay to me.  Since this depends on a qemu change,
> though, I'd like to see a qemu/kvm maintaner ack (or the dependent
> changes committed in qemu) before committing to SeaBIOS.
>
>
> Some minor nits:
>
> Patch 4:
>> +// TCG BIOS extensions
>> +void tcpa_interrupt_handler16(struct bregs *regs);
> This looks stale.
Right... missed that one.
> Patch 5:
>> +#else
>> +
>> +static u32
>> +sha1_calc(const u8 *data, u32 length, u8 *hash)
>> +{
>> +    return sha1(data, length, hash);
> I'd prefer to avoid #ifdefs - it should be possible to do something
> like:
>
> sha1_calc(...) {
>      if (CONFIG_TPM_FOR_SHA1)
>           return tpm_sha1_calc(...);
>      return sha1(...);
> }
>
Will fix.
> Finally, can you briefly describe what services that require TPM
> support will now be available to end-users with this series?
>
I'll send a V3 tomorrow explaining in each patch what the effect should be.

   Stefan