From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33029 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6z2e-0000Yb-Da for qemu-devel@nongnu.org; Tue, 05 Apr 2011 01:43:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6z2c-0002sS-RX for qemu-devel@nongnu.org; Tue, 05 Apr 2011 01:43:04 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:51713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6z2c-0002s9-J7 for qemu-devel@nongnu.org; Tue, 05 Apr 2011 01:43:02 -0400 Received: by pzk36 with SMTP id 36so20282pzk.4 for ; Mon, 04 Apr 2011 22:43:01 -0700 (PDT) Message-ID: <4D9AABE1.9030609@gmail.com> Date: Mon, 04 Apr 2011 23:42:57 -0600 From: David Ahern MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change References: <1301425482-8722-1-git-send-email-stefanha@linux.vnet.ibm.com> <1301425482-8722-4-git-send-email-stefanha@linux.vnet.ibm.com> <4D99C61E.3080600@redhat.com> <4D99C9ED.3020602@codemonkey.ws> <4D9A05D1.1000501@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Stefan Hajnoczi , Juan Quintela , libvir-list@redhat.com, qemu-devel@nongnu.org, Ryan Harper , Avi Kivity , Amit Shah On 04/04/11 23:33, Stefan Hajnoczi wrote: > On Mon, Apr 4, 2011 at 6:54 PM, David Ahern wrote: >> On 04/04/11 07:38, Anthony Liguori wrote: >>> On 04/04/2011 08:22 AM, Avi Kivity wrote: >>>> On 04/03/2011 02:57 PM, Stefan Hajnoczi wrote: >>>>> In order for media change to work with Linux host CD-ROM it is >>>>> necessary to reopen the file (otherwise the inode size will not >>>>> refresh, this is an issue with existing kernels). >>>>> >>>> >>>> Maybe we should fix the bug in Linux (and backport as necessary)? >>>> >>>> I think cd-rom assignment is sufficiently obscure that we can require >>>> a fixed kernel instead of providing a workaround. >>> >>> Do reads fail after CD change? Or do they succeed and the size is just >>> reported incorrectly? >>> >>> If it's the later, I'd agree that it needs fixing in the kernel. If >>> it's the former, I'd say it's clearly a feature. >> >> In January 2010 I was seeing old data -- data from the prior CD -- in >> the guest after the media change. > > Yikes. Is there a bug report for this? What are the steps to reproduce it? Not that I know of. It is reported by someone else last year as well: http://www.mail-archive.com/kvm@vger.kernel.org/msg32999.html > > Stefan