From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55904 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q70r8-0001Lq-S8 for qemu-devel@nongnu.org; Tue, 05 Apr 2011 03:39:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q70r2-0000De-Sw for qemu-devel@nongnu.org; Tue, 05 Apr 2011 03:39:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q70r2-0000DY-Fc for qemu-devel@nongnu.org; Tue, 05 Apr 2011 03:39:12 -0400 Message-ID: <4D9AC719.8090301@redhat.com> Date: Tue, 05 Apr 2011 10:39:05 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple References: <1301930887-20705-1-git-send-email-avi@redhat.com> <20110404155917.GA13423@redhat.com> <4D99F061.1090208@codemonkey.ws> <4D99F34D.3060804@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On 04/04/2011 08:02 PM, Blue Swirl wrote: > On Mon, Apr 4, 2011 at 7:35 PM, Avi Kivity wrote: > > On 04/04/2011 07:22 PM, Anthony Liguori wrote: > >> > >> On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote: > >>> > >>> On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: > >>>> > >>>> Many PCI BARs that use the memory address space map a single MMIO region > >>>> into > >>>> the entire BAR range. Introduce an API pci_register_bar_simple() for > >>>> that use > >>>> case, and convert all users where this can be done trivially. > >>>> > >>>> This will reduce the work required to introduce a PCI memory API; it's > >>>> also > >>>> a nice code reduction in its own right. > >>> > >>> This will save some code, so > >>> Acked-by: Michael S. Tsirkin > >>> > >>> I really hope the rest of devices will follow. > >> > >> How complete is this? > > > > I converted all devices which were easy to convert. There may be one or two > > more that can be converted with additional work (and perhaps with an > > additional pic_bar_get_current_address() API, and a pci_bar_set_coalescing() > > API). The rest likely need to stick with the callback-based API. > > In my version which I sent earlier but didn't commit, also other BARs > besides the first one and also tricky devices like VGA were handled. > > But I didn't commit it because I felt it was not going to right > direction. I think the BARs should be specified in PCIDeviceInfo > instead of adding more function calls. The same applies to this patch > set. The more complicated BARs cannot be described declaratively (at least without a lot of complicated infrastructure). They can switch from RAM to MMIO mappings at runtime, and have different sub-regions. -- error compiling committee.c: too many arguments to function