From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41983 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7289-0001fN-KK for qemu-devel@nongnu.org; Tue, 05 Apr 2011 05:00:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7287-0008Cm-LV for qemu-devel@nongnu.org; Tue, 05 Apr 2011 05:00:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7287-0008C9-BO for qemu-devel@nongnu.org; Tue, 05 Apr 2011 05:00:55 -0400 Message-ID: <4D9ADA36.8040306@redhat.com> Date: Tue, 05 Apr 2011 12:00:38 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change References: <1301425482-8722-1-git-send-email-stefanha@linux.vnet.ibm.com> <1301425482-8722-4-git-send-email-stefanha@linux.vnet.ibm.com> <4D99C61E.3080600@redhat.com> <4D99C9ED.3020602@codemonkey.ws> <4D99CC74.9070703@redhat.com> <20110405064120.GB2872@amit-x200.redhat.com> <4D9AC940.5000502@redhat.com> <20110405080900.GE2872@amit-x200.redhat.com> In-Reply-To: <20110405080900.GE2872@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Kevin Wolf , Stefan Hajnoczi , Juan Quintela , libvir-list@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Ryan Harper On 04/05/2011 11:09 AM, Amit Shah wrote: > On (Tue) 05 Apr 2011 [10:48:16], Avi Kivity wrote: > > On 04/05/2011 09:41 AM, Amit Shah wrote: > > >See http://www.spinics.net/lists/linux-scsi/msg51504.html > > > > I see this is quite fresh. What are the plans here? > > We're still discussing where the fix should be, but it certainly is a > kernel bug and should be fixed there, and then applied to stable. > > However, there are other bugs in qemu which will prevent the right > size changes to be visible in the guest (the RFC series I sent out > earlier in this thread need to be applied to QEMU at the least, the > series has grown in my development tree since the time I sent that one > out). So essentially we need to update both, the hypervisor and the > guest to get proper CDROM media change support. Why do we need to update the guest for a qemu bug? What is the qemu bug? > It also looks like we can't have a workaround in QEMU to get older > guests to work. Older guests? or older hosts? > However, a hack in the kernel can be used without any QEMU changes > (revalidate disk on each sr_open() call, irrespective of detecting any > media change). I'm against doing that for upstream, but downstreams > could do that for new guest - old hypervisor compat. Seriously confused. Please use the kernels "host kernel" and "qemu" instead of "hypervisor" which is ambiguous. -- error compiling committee.c: too many arguments to function