From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42028 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q73Wb-0003Yu-Vp
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 06:30:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <harsh@linux.vnet.ibm.com>) id 1Q73Wa-0002jB-OT
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 06:30:17 -0400
Received: from e28smtp07.in.ibm.com ([122.248.162.7]:35641)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <harsh@linux.vnet.ibm.com>) id 1Q73Wa-0002iL-51
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 06:30:16 -0400
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by e28smtp07.in.ibm.com (8.14.4/8.13.1) with ESMTP id p35AUBDB022854
	for <qemu-devel@nongnu.org>; Tue, 5 Apr 2011 16:00:11 +0530
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p35AUAGk2756792
	for <qemu-devel@nongnu.org>; Tue, 5 Apr 2011 16:00:10 +0530
Received: from d28av04.in.ibm.com (loopback [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p35AU90L009081
	for <qemu-devel@nongnu.org>; Tue, 5 Apr 2011 20:30:10 +1000
Message-ID: <4D9AEF30.5070206@linux.vnet.ibm.com>
Date: Tue, 05 Apr 2011 16:00:08 +0530
From: Harsh Bora <harsh@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1301982971-4574-1-git-send-email-harsh@linux.vnet.ibm.com>
	<BANLkTikkf5JEPAUjboQBxfg1jj0O3mHZuQ@mail.gmail.com>
In-Reply-To: <BANLkTikkf5JEPAUjboQBxfg1jj0O3mHZuQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3] v9fs_walk: As per 9p2000 RFC,
 MAXWELEM >= nwnames >= 0.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: "M. Mohan Kumar" <mohan@in.ibm.com>, jvrao@linux.vnet.ibm.com, qemu-devel@nongnu.org, "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>

On 04/05/2011 02:24 PM, Stefan Hajnoczi wrote:
> On Tue, Apr 5, 2011 at 6:56 AM, Harsh Prateek Bora
> <harsh@linux.vnet.ibm.com>  wrote:
>> The nwnames field in TWALK message is assumed to be>=0 and<= MAXWELEM
>> which is defined as macro P9_MAXWELEM (16) in virtio-9p.h as per 9p2000
>> RFC. Appropriate changes are required in V9fsWalkState and v9fs_walk.
>>
>> v3:
>> - Updated if-else conditions to appropriately handle nwnames = 0.
>>
>> v2:
>> - Added check in v9fs_walk_complete as well.
>>
>> Signed-off-by: Harsh Prateek Bora<harsh@linux.vnet.ibm.com>
>> ---
>>   hw/9pfs/virtio-9p.c |    7 +++++--
>>   hw/9pfs/virtio-9p.h |    2 +-
>>   2 files changed, 6 insertions(+), 3 deletions(-)
>
> hw/virtio-9p.c
>
> I think you've submitted a patch against an internal tree that isn't upstream.

Yes, it is based on a patch yet to be merged in mainline by Aneesh which 
will move 9p files into a separate folder, however, I shall repost an 
updated version of the patch based on current directory structure.

regards,
Harsh
>
> Stefan