From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37251 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q7CsZ-0004rz-SS
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 16:29:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q7CsX-0002r2-Vz
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 16:29:35 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:46933)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q7CsX-0002qO-TF
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 16:29:33 -0400
Received: by gyg4 with SMTP id 4so382481gyg.4
	for <qemu-devel@nongnu.org>; Tue, 05 Apr 2011 13:29:32 -0700 (PDT)
Message-ID: <4D9B7BA6.3020800@codemonkey.ws>
Date: Tue, 05 Apr 2011 15:29:26 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Questions about chardev (and ps/2 mouse)
References: <1302029716.31961.24.camel@nibbler.dlib.indiana.edu>
In-Reply-To: <1302029716.31961.24.camel@nibbler.dlib.indiana.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brian Wheeler <bdwheele@indiana.edu>
Cc: qemu-devel@nongnu.org

On 04/05/2011 01:55 PM, Brian Wheeler wrote:
> I'm trying to disable the ps/2 mouse in favor of the serial mouse
> provided by -chardev msmouse since the ps/2 mouse has had lots of
> problems with older OSes (OpenStep, OS/2, Win 3.1, etc).  I've got a
> couple of questions:
>
> 1) If I change a VMState something by appending a field (i.e.
> "unplugged"), do I have to update version_id?

Yes.  You can use a subsection though to avoid bumping the version_id.

>    How do the
> minimum_version_id{,_old} fields fit in?

This is for load, not save.  It's used to basically deprecate loading 
from very old versions.


> 2) I've had to hardcode the unplugged value in ps2_mouse_reset since the
> call is pretty deep in the call stack, 8042->pckbd->ps2.  Ideally, I'd
> like to set (*PS2MouseState)->unplugged from qemu_chr_open_msmouse() so
> that if the serial mouse is set up the ps/2 mouse would be disabled.

Wouldn't it be better to just not make the PS2Mouse present in the first 
place?

> 3) When I enable the msmouse (via -chardev msmouse,id=mouse) qemu
> segfaults.  I've traced it back to the CharDriverSTate for msmouse not
> having a valid handler_opaque (it is null).  How would I connect that to
> the serial port (any of them, but ideally the 2nd one)

I haven't looked at the chardev but I suspect it's not tested often.

Regards,

Anthony Liguori

> Thanks for any hints!
> Brian
>
>