From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60999 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7Q0X-0002EX-SJ for qemu-devel@nongnu.org; Wed, 06 Apr 2011 06:30:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7Q0W-0003bk-Pf for qemu-devel@nongnu.org; Wed, 06 Apr 2011 06:30:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7Q0W-0003bL-HT for qemu-devel@nongnu.org; Wed, 06 Apr 2011 06:30:40 -0400 Message-ID: <4D9C4151.5090201@redhat.com> Date: Wed, 06 Apr 2011 12:32:49 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1298389495-20618-1-git-send-email-nick@bytemark.co.uk> <1298389495-20618-4-git-send-email-nick@bytemark.co.uk> In-Reply-To: <1298389495-20618-4-git-send-email-nick@bytemark.co.uk> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 4/5] NBD device: Separate out parsing configuration and opening sockets. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nick Thomas Cc: stefanha@gmail.com, qemu-devel@nongnu.org Am 22.02.2011 16:44, schrieb Nick Thomas: > We also change the way the file parameter is parsed so IPv6 IP > addresses can be used, e.g.: "drive=nbd:[::1]:5000" > > Signed-off-by: Nick Thomas > --- > block/nbd.c | 157 ++++++++++++++++++++++++++++++++++++++--------------------- > 1 files changed, 102 insertions(+), 55 deletions(-) Sorry for the long delay. I have applied patches 1-4 to the block branch now. I think this one leaks s->export_name and s->host_spec, so please post a follow-up patch that fixes this on top of this patch. Patch 5 looks a bit harder to review, I'll try to get to soon anyway. One thing that you already can fix before the real review is coding style. For example, I see a lot of trailing whitespace in patch 5. Kevin