From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58245 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7UWb-0004bn-01 for qemu-devel@nongnu.org; Wed, 06 Apr 2011 11:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7UWZ-0002yW-MR for qemu-devel@nongnu.org; Wed, 06 Apr 2011 11:20:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7UWZ-0002yC-DN for qemu-devel@nongnu.org; Wed, 06 Apr 2011 11:20:03 -0400 Message-ID: <4D9C852C.5010707@redhat.com> Date: Wed, 06 Apr 2011 17:22:20 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1302086071-15742-1-git-send-email-jasowang@redhat.com> In-Reply-To: <1302086071-15742-1-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v4] floppy: save and restore DIR register List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: pbonzini@redhat.com, Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com Am 06.04.2011 12:34, schrieb Jason Wang: > We need to keep DIR register unchanged across migration, but currently it > depends on the media_changed flags from block layer. Since we do not > save/restore it and the bdrv_open() called in dest node may set the > media_changed flag when trying to open floppy image, guest driver may think the > floppy have changed after migration. To fix this, a new filed media_changed in > FDrive strcutre was introduced in order to save and restore the it from block > layer through pre_save/post_load callbacks. > > Signed-off-by: Jason Wang Thanks, applied to the block branch. Kevin