From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50682 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q7X53-0001Kt-OT
	for qemu-devel@nongnu.org; Wed, 06 Apr 2011 14:03:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q7X51-0006n4-E3
	for qemu-devel@nongnu.org; Wed, 06 Apr 2011 14:03:49 -0400
Received: from mail-yi0-f45.google.com ([209.85.218.45]:42485)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q7X51-0006mx-Bo
	for qemu-devel@nongnu.org; Wed, 06 Apr 2011 14:03:47 -0400
Received: by yib19 with SMTP id 19so830065yib.4
	for <qemu-devel@nongnu.org>; Wed, 06 Apr 2011 11:03:46 -0700 (PDT)
Message-ID: <4D9CAAF9.7000509@codemonkey.ws>
Date: Wed, 06 Apr 2011 13:03:37 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command
References: <4D74A8C9.2020408@cn.fujitsu.com>
	<4D74A974.6090509@cn.fujitsu.com>	<20110404105949.GA30324@redhat.com>
	<4D99BF99.1040305@redhat.com>	<4D99C22C.4070401@codemonkey.ws>
	<20110406144723.45333682@doriath>
In-Reply-To: <20110406144723.45333682@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Lai Jiangshan <eag0628@gmail.com>, Jiangshan <laijs@cn.fujitsu.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Avi Kivity <avi@redhat.com>

On 04/06/2011 12:47 PM, Luiz Capitulino wrote:
> On Mon, 04 Apr 2011 08:05:48 -0500
> Anthony Liguori<anthony@codemonkey.ws>  wrote:
>
>> On 04/04/2011 07:54 AM, Avi Kivity wrote:
>>> On 04/04/2011 01:59 PM, Daniel P. Berrange wrote:
>>>> Interesting that with HMP you need to specify a single CPU index, but
>>>> with QMP it is injecting to all CPUs at once. Is there any compelling
>>>> reason why we'd ever need the ability to only inject to a single CPU
>>>> from an app developer POV ?
>>> When a PC has an NMI button, it is (I presume) connected to all CPUs'
>>> LINT1 pin, which is often configured as an NMI input.  So the all-cpu
>>> variant corresponds to real hardware, while the single-cpu variant
>>> doesn't.
>>>
>>> wrt the app developer POV, the only use I'm aware of is that you can
>>> configure Windows to dump core when the NMI button is pressed and thus
>>> debug driver problems.  It's likely more reliable when sent to all cpus.
>> It either needs to be removed from HMP or added to QMP.  HMP shouldn't
>> have more features than QMP (even if those features are non-sensible).
> Is anyone against changing HMP behavior to send it to all CPUs?

Makes sense to me.

Regards,

Anthony Liguori