From: Kevin Wolf <kwolf@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
qemu list <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change
Date: Thu, 07 Apr 2011 10:59:20 +0200 [thread overview]
Message-ID: <4D9D7CE8.7070001@redhat.com> (raw)
In-Reply-To: <f6b374c65b0b3c95edc73d6b39abae1fdbcd0750.1302152648.git.amit.shah@redhat.com>
Am 07.04.2011 07:05, schrieb Amit Shah:
> We restrict the commands that a guest can send us after a cdrom change
> event. The current list includes REQUEST_SENSE and INQUIRY commands.
> Guests can also issue TEST_UNIT_READY to inquire for the status, so
> allow this command as well.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
Hm... MMC-5, section 4.1.6.1 seems to conflict with this:
"If a Host issues a command other than GET CONFIGURATION, GET EVENT
STATUS NOTIFICATION, INQUIRY or REQUEST SENSE while a unit attention
condition exists for that Host, the Drive shall not perform the command
and shall report CHECK CONDITION status unless a higher priority status
as defined by the Drive is also pending."
So while you're right that our list is incomplete, TEST UNIT READY
doesn't seem to be among the missing commands.
Kevin
next prev parent reply other threads:[~2011-04-07 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 5:05 [Qemu-devel] [PATCH v2 0/2] Correct transitions for cd change state Amit Shah
2011-04-07 5:05 ` [Qemu-devel] [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change Amit Shah
2011-04-07 7:22 ` [Qemu-devel] " Paolo Bonzini
2011-04-07 8:42 ` Stefan Hajnoczi
2011-04-07 8:51 ` Amit Shah
2011-04-07 8:59 ` Kevin Wolf [this message]
2011-04-07 9:11 ` Amit Shah
2011-04-07 10:20 ` Kevin Wolf
2011-04-07 11:15 ` Amit Shah
2011-04-07 5:05 ` [Qemu-devel] [PATCH v2 2/2] cdrom: Make disc change event visible to guests Amit Shah
2011-04-07 7:31 ` [Qemu-devel] " Paolo Bonzini
2011-04-07 8:01 ` Amit Shah
2011-04-07 8:41 ` Stefan Hajnoczi
2011-04-07 8:51 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9D7CE8.7070001@redhat.com \
--to=kwolf@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).