From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56441 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q7lUT-0002zk-76
	for qemu-devel@nongnu.org; Thu, 07 Apr 2011 05:27:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Q7lUR-00017o-Jk
	for qemu-devel@nongnu.org; Thu, 07 Apr 2011 05:27:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38430)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Q7lUR-00017c-Ah
	for qemu-devel@nongnu.org; Thu, 07 Apr 2011 05:26:59 -0400
Message-ID: <4D9D835C.60107@redhat.com>
Date: Thu, 07 Apr 2011 11:26:52 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1302165882.git.amit.shah@redhat.com>
In-Reply-To: <cover.1302165882.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3 0/2] Correct transitions for cd change
	state
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Gleb Natapov <gleb@redhat.com>, Juan Quintela <quintela@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu list <qemu-devel@nongnu.org>

On 04/07/2011 10:46 AM, Amit Shah wrote:
> Hello,
>
> These two patches fix the cd media size change bugs.
>
> The test scenario is:
>
> 1. create an iso image from a file
> 2. create a second iso image from a bigger file
> 3. mount 1st cd in guest
> 4. unmount it
> 5. change cd via qemu monitor
> 6. mount 2nd cd
> 7. copy file on cd to local disk -- shows errors.
>
> v2: Set media_change_notified to 1 if SENSE_UNIT_ATTENTION is not set
> after migration.  This is the only thing needed for migration compat.
>
> v3:
>   - Use cdrom_changed to hold all state changes instead of introducing
>     a new variable. (Paolo Bonzini)
>   - Slightly better comment and commit messages
>
> Please apply.
>
> Amit Shah (2):
>    cdrom: Allow the TEST_UNIT_READY command after a cdrom change
>    cdrom: Make disc change event visible to guests
>
>   hw/ide/core.c |   56 +++++++++++++++++++++++++++++++++++++++++++++++---------
>   1 files changed, 47 insertions(+), 9 deletions(-)
>

Thanks!

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo