From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39968 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7peH-0007Ny-Q8 for qemu-devel@nongnu.org; Thu, 07 Apr 2011 09:53:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7peG-0005Nc-Jx for qemu-devel@nongnu.org; Thu, 07 Apr 2011 09:53:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7peG-0005N2-Ba for qemu-devel@nongnu.org; Thu, 07 Apr 2011 09:53:24 -0400 Message-ID: <4D9DC25D.6090808@redhat.com> Date: Thu, 07 Apr 2011 15:55:41 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] virtio-blk: fail unaligned requests References: <20110406182834.GA471@lst.de> In-Reply-To: <20110406182834.GA471@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: Conor Murphy , qemu-devel@nongnu.org Am 06.04.2011 20:28, schrieb Christoph Hellwig: > Like all block drivers virtio-blk should not allow small than block size > granularity access. But given that the protocol specifies a > byte unit length field we currently accept such requests, which cause > qemu to abort() in lower layers. Add checks to the main read and > write handlers to catch them early. > > Reported-by: Conor Murphy > Tested-by: Conor Murphy > Signed-off-by: Christoph Hellwig Thanks, applied to the block branch. Kevin