From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40580 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q7wwt-0001xe-3N
	for qemu-devel@nongnu.org; Thu, 07 Apr 2011 17:41:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q7wwr-0007Jc-Ui
	for qemu-devel@nongnu.org; Thu, 07 Apr 2011 17:41:06 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:41944)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q7wwr-0007JY-SR
	for qemu-devel@nongnu.org; Thu, 07 Apr 2011 17:41:05 -0400
Received: by gxk26 with SMTP id 26so1471475gxk.4
	for <qemu-devel@nongnu.org>; Thu, 07 Apr 2011 14:41:05 -0700 (PDT)
Message-ID: <4D9E2F6F.3040008@codemonkey.ws>
Date: Thu, 07 Apr 2011 16:41:03 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command
References: <4D9CAAF9.7000509@codemonkey.ws>
	<20110406150818.56707b9b@doriath>	<4D9CAE4B.7080305@siemens.com>
	<20110406160020.373cb5a2@doriath>	<BANLkTinUfnq6b2u_bfdB_zc3z8dg=4gAbA@mail.gmail.com>	<4D9CC044.2000705@codemonkey.ws>	<BANLkTim4iP_YRjOCYH986BB=ec-dwcjfQA@mail.gmail.com>	<4D9E0352.2050204@codemonkey.ws>
	<20110407185108.GE7100@redhat.com>	<BANLkTi=Kn7gArGY9ZVqY465_bgumMZhEfg@mail.gmail.com>
	<20110407191759.GG7100@redhat.com>
In-Reply-To: <20110407191759.GG7100@redhat.com>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Lai Jiangshan <eag0628@gmail.com>, Jiangshan <laijs@cn.fujitsu.com>, kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On 04/07/2011 02:17 PM, Gleb Natapov wrote:
> On Thu, Apr 07, 2011 at 10:04:00PM +0300, Blue Swirl wrote:
>> On Thu, Apr 7, 2011 at 9:51 PM, Gleb Natapov<gleb@redhat.com>  wrote:
>>
>> I'd prefer something more generic like these:
>> raise /apic@fee00000:l1int
>> lower /i44FX-pcihost/e1000@03.0/pinD
>>
>> The clumsier syntax shouldn't be a problem, since this would be a
>> system developer tool.
>>
>> Some kind of IRQ registration would be needed for this to work without
>> lots of changes.
> True. The ability to trigger any interrupt line is very useful for
> debugging. I often re-implement it during debug.

And it's a good thing to have, but exposing this as the only API to do 
something as simple as generating a guest crash dump is not the 
friendliest thing in the world to do to users.

Regards,

Anthony Liguori

> --
> 			Gleb.
>