From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45472 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q8616-0002WH-MS
	for qemu-devel@nongnu.org; Fri, 08 Apr 2011 03:22:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Q8615-0005Qo-4V
	for qemu-devel@nongnu.org; Fri, 08 Apr 2011 03:22:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11897)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Q8614-0005QC-Px
	for qemu-devel@nongnu.org; Fri, 08 Apr 2011 03:22:03 -0400
Message-ID: <4D9EB792.5070308@redhat.com>
Date: Fri, 08 Apr 2011 09:21:54 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1302246567.git.amit.shah@redhat.com>
In-Reply-To: <cover.1302246567.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/5] atapi: Implement 'media' subcommand
	for GESN
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Juan Quintela <quintela@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu list <qemu-devel@nongnu.org>

On 04/08/2011 09:15 AM, Amit Shah wrote:
> The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a
> mandatory command in the spec but we don't really implement it any of
> its sub-commands.
>
> The commit message for the last commit explains why implementing just
> the media subcommand is helpful and how it goes a long way in getting
> guests to behave as expected.
>
> The difference from the RFC series sent earlier is:
> - Split into more patches
> - Add tray open/close notification (from Markus)
>
> There certainly is much more work to be done for the other commands
> and also for state change handling (tray open / close / new media)
> overall for the block layer, but this is a good first step in being
> spec-compliant and at the same time making guests work.
>
> Please apply!
>
> Amit Shah (5):
>    atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change
>    ide: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own
>      function
>    atapi: GESN: Spin off No Event Available handling into own function
>    atapi: GESN: Add enums for commonly-used field types
>    atapi: Implement 'media' subcommand of GET_EVENT_STATUS_NOTIFICATION
>      command
>
>   hw/ide/core.c     |  172 +++++++++++++++++++++++++++++++++++++++++++++++-----
>   hw/ide/internal.h |    6 ++
>   2 files changed, 161 insertions(+), 17 deletions(-)
>

ACK patches 1-3.

For 4 and 5, I don't think lowercase enums are used in QEMU.  I'm 
downloading the spec now so I can do a more complete review as well.

Paolo