From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39263 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q89Qj-000763-0v for qemu-devel@nongnu.org; Fri, 08 Apr 2011 07:00:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q89Qi-0000HT-3M for qemu-devel@nongnu.org; Fri, 08 Apr 2011 07:00:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q89Qh-0000H3-Ly for qemu-devel@nongnu.org; Fri, 08 Apr 2011 07:00:44 -0400 Message-ID: <4D9EEB65.8020201@redhat.com> Date: Fri, 08 Apr 2011 13:03:01 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change References: <7dad199c525d4b2079658b090b210472f433e1c9.1302246567.git.amit.shah@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Amit Shah , Stefan Hajnoczi , Paolo Bonzini , qemu list , Juan Quintela Am 08.04.2011 12:54, schrieb Markus Armbruster: > Amit Shah writes: > >> After a media change, the only commands allowed from the guest were >> REQUEST_SENSE and INQUIRY. The guest may also issue >> GET_EVENT_STATUS_NOTIFICATION commands to get media >> changed notification. >> >> After this, the HSM violation messages from Linux guests aren't seen. >> >> Signed-off-by: Amit Shah >> --- >> hw/ide/core.c | 9 +++++---- >> 1 files changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/hw/ide/core.c b/hw/ide/core.c >> index c11d457..327f703 100644 >> --- a/hw/ide/core.c >> +++ b/hw/ide/core.c >> @@ -1105,10 +1105,11 @@ static void ide_atapi_cmd(IDEState *s) >> /* If there's a UNIT_ATTENTION condition pending, only >> REQUEST_SENSE and INQUIRY commands are allowed to complete. */ > > Comment is now stale. I doubt it's terribly useful for anyone capable > of reading C, but as long as it's there, it better be accurate. You can make it useful by pointing to the right section in MMC (and listing the commands that should be allowed according to the standard as long as it differs from what we implement today). Kevin