From: Kevin Wolf <kwolf@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
qemu list <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 3/5] atapi: GESN: Spin off No Event Available handling into own function
Date: Fri, 08 Apr 2011 15:31:49 +0200 [thread overview]
Message-ID: <4D9F0E45.6000005@redhat.com> (raw)
In-Reply-To: <8c4effc5d537fe0a35791e2f970ede8ed400b5bd.1302246567.git.amit.shah@redhat.com>
Am 08.04.2011 09:15, schrieb Amit Shah:
> Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available status in its
> own function.
>
> Also ensure the buffer the driver sent us is big enough to fill in all
> the data we have -- else just fill in as much as the buffer can hold.
This is unnecessary and in fact none of the IDE code does this.
s->io_buffer isn't guest memory, but an internal buffer that is
allocated like this:
s->io_buffer = qemu_memalign(2048, IDE_DMA_BUF_SECTORS*512 + 4);
So that's more than enough for storing four bytes. ide_atapi_cmd_reply()
takes care of making only max_size bytes visible to the guest.
Kevin
next prev parent reply other threads:[~2011-04-08 13:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 7:15 [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN Amit Shah
2011-04-08 7:15 ` [Qemu-devel] [PATCH 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change Amit Shah
2011-04-08 7:25 ` [Qemu-devel] " Amit Shah
2011-04-08 10:54 ` [Qemu-devel] " Markus Armbruster
2011-04-08 11:03 ` Kevin Wolf
2011-04-08 7:15 ` [Qemu-devel] [PATCH 2/5] ide: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function Amit Shah
2011-04-08 7:15 ` [Qemu-devel] [PATCH 3/5] atapi: GESN: Spin off No Event Available handling into " Amit Shah
2011-04-08 13:31 ` Kevin Wolf [this message]
2011-04-09 10:36 ` [Qemu-devel] " Amit Shah
2011-04-11 8:51 ` Kevin Wolf
2011-04-08 7:15 ` [Qemu-devel] [PATCH 4/5] atapi: GESN: Add enums for commonly-used field types Amit Shah
2011-04-08 14:21 ` [Qemu-devel] " Kevin Wolf
2011-04-09 10:43 ` Amit Shah
2011-04-08 7:15 ` [Qemu-devel] [PATCH 5/5] atapi: Implement 'media' subcommand of GET_EVENT_STATUS_NOTIFICATION command Amit Shah
2011-04-08 16:17 ` [Qemu-devel] " Kevin Wolf
2011-04-09 13:57 ` Amit Shah
2011-04-08 7:21 ` [Qemu-devel] Re: [PATCH 0/5] atapi: Implement 'media' subcommand for GESN Paolo Bonzini
2011-04-08 9:39 ` [Qemu-devel] " Markus Armbruster
2011-04-11 6:18 ` Amit Shah
2011-04-11 13:46 ` Markus Armbruster
2011-04-12 4:22 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9F0E45.6000005@redhat.com \
--to=kwolf@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).