From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51815 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q8DtN-0000KG-Ho
	for qemu-devel@nongnu.org; Fri, 08 Apr 2011 11:46:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q8DtM-0004jq-F0
	for qemu-devel@nongnu.org; Fri, 08 Apr 2011 11:46:37 -0400
Received: from mail-iy0-f173.google.com ([209.85.210.173]:52788)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Q8DtM-0004je-6M
	for qemu-devel@nongnu.org; Fri, 08 Apr 2011 11:46:36 -0400
Received: by iym10 with SMTP id 10so4351086iym.4
	for <qemu-devel@nongnu.org>; Fri, 08 Apr 2011 08:46:34 -0700 (PDT)
Message-ID: <4D9F2DD6.9080400@codemonkey.ws>
Date: Fri, 08 Apr 2011 10:46:30 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 1/5] hpet 'driftfix': add hooks required
	to detect coalesced interrupts (x86 apic only)
References: <1302276042-3497-1-git-send-email-uobergfe@redhat.com>
	<1302276042-3497-2-git-send-email-uobergfe@redhat.com>
In-Reply-To: <1302276042-3497-2-git-send-email-uobergfe@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ulrich Obergfell <uobergfe@redhat.com>
Cc: jan.kiszka@siemens.com, avi@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, gcosta@redhat.com

On 04/08/2011 10:20 AM, Ulrich Obergfell wrote:
> 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain
> entry addresses of functions that are utilized by update_irq() to
> detect coalesced interrupts. apic code loads these pointers during
> initialization.
>
> Signed-off-by: Ulrich Obergfell<uobergfe@redhat.com>
> ---
>   hw/apic.c |    4 ++++
>   sysemu.h  |    3 +++
>   vl.c      |    3 +++
>   3 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/hw/apic.c b/hw/apic.c
> index 00907e0..44d8cb3 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -24,6 +24,7 @@
>   #include "sysbus.h"
>   #include "trace.h"
>   #include "kvm.h"
> +#include "sysemu.h"
>
>   /* APIC Local Vector Table */
>   #define APIC_LVT_TIMER   0
> @@ -1143,6 +1144,9 @@ static SysBusDeviceInfo apic_info = {
>
>   static void apic_register_devices(void)
>   {
> +    target_get_irq_delivered = apic_get_irq_delivered;
> +    target_reset_irq_delivered = apic_reset_irq_delivered;
> +
>       sysbus_register_withprop(&apic_info);
>   }
>
> diff --git a/sysemu.h b/sysemu.h
> index 3f7e17e..b5d4f90 100644
> --- a/sysemu.h
> +++ b/sysemu.h
> @@ -96,6 +96,9 @@ int qemu_savevm_state_complete(Monitor *mon, QEMUFile *f);
>   void qemu_savevm_state_cancel(Monitor *mon, QEMUFile *f);
>   int qemu_loadvm_state(QEMUFile *f);
>
> +extern int (*target_get_irq_delivered)(void);
> +extern void (*target_reset_irq_delivered)(void);

It's a bit nicer to use a registration function instead of setting a 
global function pointer directly.

Regards,

Anthony Liguori

> +
>   /* SLIRP */
>   void do_info_slirp(Monitor *mon);
>
> diff --git a/vl.c b/vl.c
> index 8bcf2ae..548912a 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -231,6 +231,9 @@ const char *prom_envs[MAX_PROM_ENVS];
>   const char *nvram = NULL;
>   int boot_menu;
>
> +int (*target_get_irq_delivered)(void) = 0;
> +void (*target_reset_irq_delivered)(void) = 0;
> +
>   typedef struct FWBootEntry FWBootEntry;
>
>   struct FWBootEntry {