[Qemu-devel] [PATCH] configure: avoid basename usage message

[Qemu-devel] [PATCH] configure: avoid basename usage message

[Scott Wood]

basename prints a missing-argument error when sdlconfig is empty
and we're cross-compiling.

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
 configure |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index ae97e11..c5b85fe 100755
--- a/configure
+++ b/configure
@@ -1233,7 +1233,8 @@ else
   fi
   sdl=no
 fi
-if test -n "$cross_prefix" && test "`basename $sdlconfig`" = sdl-config; then
+if test -n "$cross_prefix" -a -n "$sdlconfig" && \
+   test "`basename $sdlconfig`" = sdl-config; then
   echo warning: using "\"$sdlconfig\"" to detect cross-compiled sdl >&2
 fi
 
-- 
1.7.1

Re: [Qemu-devel] [PATCH] configure: avoid basename usage message

[Stefan Hajnoczi]

On Fri, Apr 08, 2011 at 11:33:49AM -0500, Scott Wood wrote:
> diff --git a/configure b/configure
> index ae97e11..c5b85fe 100755
> --- a/configure
> +++ b/configure
> @@ -1233,7 +1233,8 @@ else
>    fi
>    sdl=no
>  fi
> -if test -n "$cross_prefix" && test "`basename $sdlconfig`" = sdl-config; then
> +if test -n "$cross_prefix" -a -n "$sdlconfig" && \
> +   test "`basename $sdlconfig`" = sdl-config; then

Instead of doing test -n "$sdlconfig" first with short-circuit
evaluation, I think would should do:

test $(basename "$sdlconfig") = sdl-config

Then you don't need to test sdlconfig because basename will produce an
empty string without error.

Stefan

[Qemu-devel] [PATCH v2] configure: avoid basename usage message

[Scott Wood]

basename prints a missing-argument error when sdlconfig is empty
and we're cross-compiling.

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
v2: quote the input to basename rather than introduce an extra test,
as suggested by Stefan.

 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index ae97e11..2bb3faa 100755
--- a/configure
+++ b/configure
@@ -1233,7 +1233,7 @@ else
   fi
   sdl=no
 fi
-if test -n "$cross_prefix" && test "`basename $sdlconfig`" = sdl-config; then
+if test -n "$cross_prefix" && test "$(basename "$sdlconfig")" = sdl-config; then
   echo warning: using "\"$sdlconfig\"" to detect cross-compiled sdl >&2
 fi
 
-- 
1.7.1

Re: [Qemu-devel] [PATCH] configure: avoid basename usage message

[Anthony Liguori]

On 04/08/2011 01:56 PM, Stefan Hajnoczi wrote:
> On Fri, Apr 08, 2011 at 11:33:49AM -0500, Scott Wood wrote:
>> diff --git a/configure b/configure
>> index ae97e11..c5b85fe 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1233,7 +1233,8 @@ else
>>     fi
>>     sdl=no
>>   fi
>> -if test -n "$cross_prefix"&&  test "`basename $sdlconfig`" = sdl-config; then
>> +if test -n "$cross_prefix" -a -n "$sdlconfig"&&  \
>> +   test "`basename $sdlconfig`" = sdl-config; then
> Instead of doing test -n "$sdlconfig" first with short-circuit
> evaluation, I think would should do:
>
> test $(basename "$sdlconfig") = sdl-config

$() is a bash-ism FYI.

Regards,

Anthony Liguori

> Then you don't need to test sdlconfig because basename will produce an
> empty string without error.
>
> Stefan
>

Re: [Qemu-devel] [PATCH] configure: avoid basename usage message

[Scott Wood]

On Fri, 8 Apr 2011 15:06:57 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:

> On 04/08/2011 01:56 PM, Stefan Hajnoczi wrote:
> > On Fri, Apr 08, 2011 at 11:33:49AM -0500, Scott Wood wrote:
> >> diff --git a/configure b/configure
> >> index ae97e11..c5b85fe 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -1233,7 +1233,8 @@ else
> >>     fi
> >>     sdl=no
> >>   fi
> >> -if test -n "$cross_prefix"&&  test "`basename $sdlconfig`" = sdl-config; then
> >> +if test -n "$cross_prefix" -a -n "$sdlconfig"&&  \
> >> +   test "`basename $sdlconfig`" = sdl-config; then
> > Instead of doing test -n "$sdlconfig" first with short-circuit
> > evaluation, I think would should do:
> >
> > test $(basename "$sdlconfig") = sdl-config
> 
> $() is a bash-ism FYI.

See section 2.6.3 of
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html

And I've tested that it works in dash.

-Scott

[Qemu-devel] Re: [PATCH v2] configure: avoid basename usage message

[Stefan Hajnoczi]

On Fri, Apr 08, 2011 at 02:15:50PM -0500, Scott Wood wrote:
> basename prints a missing-argument error when sdlconfig is empty
> and we're cross-compiling.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> v2: quote the input to basename rather than introduce an extra test,
> as suggested by Stefan.
> 
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

I have merged into the trivial patches tree since $() is POSIX and we
already use it in ./configure:
git://repo.or.cz/qemu/stefanha.git trivial-patches

A pull request will be sent to merge this into qemu.git.  For more
information, see http://wiki.qemu.org/Contribute/TrivialPatches.

Stefan