* [Qemu-devel] [PATCH] musicpal: Fix registration of MMIO-less sysbus devices
@ 2011-04-10 7:35 Jan Kiszka
2011-04-10 12:31 ` [Qemu-devel] " Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2011-04-10 7:35 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Aurelien Jarno
The proper way to signal that a sysbus devices need no MMIO region is to
pass -1 to sysbus_create_simple.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
hw/musicpal.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/musicpal.c b/hw/musicpal.c
index d98aa8d..52b2931 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -1597,11 +1597,11 @@ static void musicpal_init(ram_addr_t ram_size,
musicpal_misc_init();
dev = sysbus_create_simple("musicpal_gpio", MP_GPIO_BASE, pic[MP_GPIO_IRQ]);
- i2c_dev = sysbus_create_simple("gpio_i2c", 0, NULL);
+ i2c_dev = sysbus_create_simple("gpio_i2c", -1, NULL);
i2c = (i2c_bus *)qdev_get_child_bus(i2c_dev, "i2c");
lcd_dev = sysbus_create_simple("musicpal_lcd", MP_LCD_BASE, NULL);
- key_dev = sysbus_create_simple("musicpal_key", 0, NULL);
+ key_dev = sysbus_create_simple("musicpal_key", -1, NULL);
/* I2C read data */
qdev_connect_gpio_out(i2c_dev, 0,
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [PATCH] musicpal: Fix registration of MMIO-less sysbus devices
2011-04-10 7:35 [Qemu-devel] [PATCH] musicpal: Fix registration of MMIO-less sysbus devices Jan Kiszka
@ 2011-04-10 12:31 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2011-04-10 12:31 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Peter Maydell, qemu-devel
On Sun, Apr 10, 2011 at 09:35:42AM +0200, Jan Kiszka wrote:
> The proper way to signal that a sysbus devices need no MMIO region is to
> pass -1 to sysbus_create_simple.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
> hw/musicpal.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied.
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index d98aa8d..52b2931 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1597,11 +1597,11 @@ static void musicpal_init(ram_addr_t ram_size,
> musicpal_misc_init();
>
> dev = sysbus_create_simple("musicpal_gpio", MP_GPIO_BASE, pic[MP_GPIO_IRQ]);
> - i2c_dev = sysbus_create_simple("gpio_i2c", 0, NULL);
> + i2c_dev = sysbus_create_simple("gpio_i2c", -1, NULL);
> i2c = (i2c_bus *)qdev_get_child_bus(i2c_dev, "i2c");
>
> lcd_dev = sysbus_create_simple("musicpal_lcd", MP_LCD_BASE, NULL);
> - key_dev = sysbus_create_simple("musicpal_key", 0, NULL);
> + key_dev = sysbus_create_simple("musicpal_key", -1, NULL);
>
> /* I2C read data */
> qdev_connect_gpio_out(i2c_dev, 0,
> --
> 1.7.1
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-10 12:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-10 7:35 [Qemu-devel] [PATCH] musicpal: Fix registration of MMIO-less sysbus devices Jan Kiszka
2011-04-10 12:31 ` [Qemu-devel] " Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).