From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35880 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8pBR-00051Z-Vw for qemu-devel@nongnu.org; Sun, 10 Apr 2011 03:35:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8pBQ-0005a2-3P for qemu-devel@nongnu.org; Sun, 10 Apr 2011 03:35:44 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:41991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8pBP-0005Zo-Rt for qemu-devel@nongnu.org; Sun, 10 Apr 2011 03:35:44 -0400 Message-ID: <4DA15DCE.3000206@web.de> Date: Sun, 10 Apr 2011 09:35:42 +0200 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH] musicpal: Fix registration of MMIO-less sysbus devices List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: Peter Maydell , Aurelien Jarno The proper way to signal that a sysbus devices need no MMIO region is to pass -1 to sysbus_create_simple. Signed-off-by: Jan Kiszka --- hw/musicpal.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index d98aa8d..52b2931 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -1597,11 +1597,11 @@ static void musicpal_init(ram_addr_t ram_size, musicpal_misc_init(); dev = sysbus_create_simple("musicpal_gpio", MP_GPIO_BASE, pic[MP_GPIO_IRQ]); - i2c_dev = sysbus_create_simple("gpio_i2c", 0, NULL); + i2c_dev = sysbus_create_simple("gpio_i2c", -1, NULL); i2c = (i2c_bus *)qdev_get_child_bus(i2c_dev, "i2c"); lcd_dev = sysbus_create_simple("musicpal_lcd", MP_LCD_BASE, NULL); - key_dev = sysbus_create_simple("musicpal_key", 0, NULL); + key_dev = sysbus_create_simple("musicpal_key", -1, NULL); /* I2C read data */ qdev_connect_gpio_out(i2c_dev, 0, -- 1.7.1