From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37664 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q8qO8-0005Gc-O0
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 04:52:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Q8qNw-0006PL-5J
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 04:52:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39658)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Q8qNv-0006Ot-PQ
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 04:52:44 -0400
Message-ID: <4DA16FCB.7040509@redhat.com>
Date: Sun, 10 Apr 2011 11:52:27 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command
References: <4D9CAAF9.7000509@codemonkey.ws>
	<20110406150818.56707b9b@doriath>	<4D9CAE4B.7080305@siemens.com>
	<20110406160020.373cb5a2@doriath>	<BANLkTinUfnq6b2u_bfdB_zc3z8dg=4gAbA@mail.gmail.com>	<4D9CC044.2000705@codemonkey.ws>	<BANLkTim4iP_YRjOCYH986BB=ec-dwcjfQA@mail.gmail.com>	<4D9E0352.2050204@codemonkey.ws>
	<20110407185108.GE7100@redhat.com>	<BANLkTi=Kn7gArGY9ZVqY465_bgumMZhEfg@mail.gmail.com>
	<20110407191759.GG7100@redhat.com> <4D9E2F6F.3040008@codemonkey.ws>
In-Reply-To: <4D9E2F6F.3040008@codemonkey.ws>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, Lai Jiangshan <eag0628@gmail.com>, Jiangshan <laijs@cn.fujitsu.com>, Gleb Natapov <gleb@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, kvm@vger.kernel.org, Luiz Capitulino <lcapitulino@redhat.com>

On 04/08/2011 12:41 AM, Anthony Liguori wrote:
>
> And it's a good thing to have, but exposing this as the only API to do 
> something as simple as generating a guest crash dump is not the 
> friendliest thing in the world to do to users.

nmi is a fine name for something that corresponds to a real-life nmi 
button (often labeled "NMI").

generate-crash-dump is a wrong name for something that doesn't generate 
a crash dump (the guest may not be configured for it, or it may fail to 
work).  I'd expect that to be host-side functionality.

-- 
error compiling committee.c: too many arguments to function