From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth@twiddle.net>) id 1Q9SoX-0003xN-Ry
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 21:54:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth@twiddle.net>) id 1Q9Jmd-0003zw-TC
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 12:16:12 -0400
Received: from b.mail.sonic.net ([64.142.19.5]:41583)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth@twiddle.net>) id 1Q9Jmd-0003ye-BP
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 12:16:11 -0400
Message-ID: <4DA31C0B.20407@twiddle.net>
Date: Mon, 11 Apr 2011 08:19:39 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1302462785-8672-1-git-send-email-aurelien@aurel32.net>	<20110411145502.GY23480@codesourcery.com>
	<BANLkTi=_0Sw4m7ECy-P7YJz8f_8YvJHkrg@mail.gmail.com>
In-Reply-To: <BANLkTi=_0Sw4m7ECy-P7YJz8f_8YvJHkrg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-sh4: get rid of CPU_{Float, Double}U
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org, Nathan Froyd <froydnj@codesourcery.com>

On 04/11/2011 08:09 AM, Peter Maydell wrote:
> (4) I think you should be able to write a helper function for an
> add as just
>  float32 HELPER(my_float_add)(float32 a, float32 b) {
>      return float32_add(a, b, status);
>  }

While this is a laudable goal, this will fail for hosts that pass
all structures by reference.  This is true of, e.g. PPC32.


r~