From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>,
qemu-devel@nongnu.org, Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] target-sh4: get rid of CPU_{Float, Double}U
Date: Mon, 11 Apr 2011 08:32:26 -0700 [thread overview]
Message-ID: <4DA31F0A.9080700@twiddle.net> (raw)
In-Reply-To: <BANLkTikcC4TSp+3znAc4yt_O37iY4jUihg@mail.gmail.com>
On 04/11/2011 08:30 AM, Peter Maydell wrote:
> On 11 April 2011 16:19, Richard Henderson <rth@twiddle.net> wrote:
>> On 04/11/2011 08:09 AM, Peter Maydell wrote:
>>> (4) I think you should be able to write a helper function for an
>>> add as just
>>> float32 HELPER(my_float_add)(float32 a, float32 b) {
>>> return float32_add(a, b, status);
>>> }
>>
>> While this is a laudable goal, this will fail for hosts that pass
>> all structures by reference. This is true of, e.g. PPC32.
>
> ...but only if float32 is a struct, which is where we came in.
> In the sane default configuration float32 is just a uint32_t
> in disguise.
Well, that's all right then. So long as we restrict ourselves
to passing around (typedefed) integers and pointers only, we'll
be ok.
r~
next prev parent reply other threads:[~2011-04-12 1:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 19:13 [Qemu-devel] [PATCH] target-sh4: get rid of CPU_{Float,Double}U Aurelien Jarno
2011-04-11 14:55 ` [Qemu-devel] Re: [PATCH] target-sh4: get rid of CPU_{Float, Double}U Nathan Froyd
2011-04-11 15:09 ` Peter Maydell
2011-04-11 15:19 ` [Qemu-devel] " Richard Henderson
2011-04-11 15:30 ` [Qemu-devel] " Peter Maydell
2011-04-11 15:32 ` Richard Henderson [this message]
2011-04-11 15:31 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA31F0A.9080700@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=froydnj@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).