From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9dBX-0005HQ-NV for qemu-devel@nongnu.org; Tue, 12 Apr 2011 08:59:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9dBW-0002pi-Ss for qemu-devel@nongnu.org; Tue, 12 Apr 2011 08:59:11 -0400 Received: from david.siemens.de ([192.35.17.14]:15675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9dBW-0002ox-Js for qemu-devel@nongnu.org; Tue, 12 Apr 2011 08:59:10 -0400 Message-ID: <4DA44C98.7010302@siemens.com> Date: Tue, 12 Apr 2011 14:59:04 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1302460123-25704-1-git-send-email-weil@mail.berlios.de> <1302460123-25704-5-git-send-email-weil@mail.berlios.de> <4DA2AF8F.4000308@redhat.com> <4DA3387C.3060406@mail.berlios.de> <4DA44765.8090804@siemens.com> <4DA44832.3080206@redhat.com> In-Reply-To: <4DA44832.3080206@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] qemu-timer: Fix timers for w32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Anthony Liguori , QEMU Developers On 2011-04-12 14:40, Paolo Bonzini wrote: > On 04/12/2011 02:36 PM, Jan Kiszka wrote: >>> I see the same bug here with two XP hosts and also tried both timer >>> variants >>> of current QEMU (without a difference). >>> >>> I don't get the bug when running on a Linux host using wine. >> >> Passing no_timer_check to the Linux guest should work around the issue >> as well. But this feature is only available since 2.6.20 (excluding >> popular legacy 2.6.16 kernels). > > I think adding back MM timers is fine, especially since a bug that only > happens under native Windows is a bug I'm unlikely to look at... That wasn't meant as a vote against changing the Windows code paths, just as a further hint how to work-around virtualization related effects. Even with high-res timers, you may hit that issue once in a while, also on Linux hosts. When using KVM, latest Linux guest will notice that they are running on a hypervisor and should skip the test automatically IIRC. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux