From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Q9eDG-00012g-UL
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 10:05:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Q9eDG-0003P1-24
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 10:05:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40123)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Q9eDF-0003OO-N2
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 10:05:02 -0400
Message-ID: <4DA45C9B.9040904@redhat.com>
Date: Tue, 12 Apr 2011 16:07:23 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <cover.1302608369.git.amit.shah@redhat.com>
	<2170ea9881efc68cd2265b9df956a30eb689b8cc.1302608369.git.amit.shah@redhat.com>
	<4DA44F0D.2020506@redhat.com>
	<20110412135913.GA13631@amit-x200.redhat.com>
In-Reply-To: <20110412135913.GA13631@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event
 response handling for future additions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu list <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

Am 12.04.2011 15:59, schrieb Amit Shah:
> On (Tue) 12 Apr 2011 [15:09:33], Kevin Wolf wrote:
>> Am 12.04.2011 13:43, schrieb Amit Shah:
>>> Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a
>>> generic way so that future additions to the code to handle other
>>> response types is easier.
>>>
>>> Signed-off-by: Amit Shah <amit.shah@redhat.com>
>>> ---
>>>  hw/ide/core.c |   24 +++++++++++++++++++-----
>>>  1 files changed, 19 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/hw/ide/core.c b/hw/ide/core.c
>>> index e838990..a9bc1e3 100644
>>> --- a/hw/ide/core.c
>>> +++ b/hw/ide/core.c
>>> @@ -1098,9 +1098,17 @@ static void handle_get_event_status_notification(IDEState *s,
>>>          uint8_t control;
>>>      } __attribute__((packed)) *gesn_cdb;
>>>  
>>> +    struct {
>>> +        uint16_t len;
>>> +        uint8_t notification_class;
>>> +        uint8_t supported_events;
>>> +    } __attribute((packed)) *gesn_event_header;
>>> +
>>>      unsigned int max_len, used_len;
>>>  
>>>      gesn_cdb = (void *)packet;
>>> +    gesn_event_header = (void *)packet;
>>
>> I think this should be buf, not packet.
> 
> Ah, right.  (Though they're the same.)

Oh, you're right. I wasn't even aware of that. At some point we should
clean this up, it's an invitation for bugs...

Kevin