From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu list <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Amit Shah <amit.shah@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement 'media' subcommand
Date: Tue, 12 Apr 2011 17:13:00 +0200 [thread overview]
Message-ID: <4DA46BFC.5090003@redhat.com> (raw)
In-Reply-To: <4DA46C1E.1000105@redhat.com>
On 04/12/11 17:13, Kevin Wolf wrote:
> Am 12.04.2011 17:03, schrieb Jes Sorensen:
>> Shouldn't you verify that you don't exceed max_len in this?
>
> Not necessary (the buffer is always 2048 bytes), but it looks like the
> max_len parameter is unused now, so it could be removed.
>
> Kevin
That works fine too - I just didn't like having a length and then having
it ignored completely.
Cheers,
Jes
prev parent reply other threads:[~2011-04-12 15:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 14:09 [Qemu-devel] [PATCH v4 0/5] atapi: Implement 'media' subcommand for GESN Amit Shah
2011-04-12 14:09 ` [Qemu-devel] [PATCH v4 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change Amit Shah
2011-04-12 14:09 ` [Qemu-devel] [PATCH v4 2/5] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function Amit Shah
2011-04-12 14:09 ` [Qemu-devel] [PATCH v4 3/5] atapi: GESN: Use structs for commonly-used field types Amit Shah
2011-04-12 14:09 ` [Qemu-devel] [PATCH v4 4/5] atapi: GESN: Standardise event response handling for future additions Amit Shah
2011-04-12 14:09 ` [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement 'media' subcommand Amit Shah
2011-04-12 14:54 ` Kevin Wolf
2011-04-12 15:03 ` Amit Shah
2011-04-12 15:05 ` Amit Shah
2011-04-12 15:11 ` Kevin Wolf
2011-04-12 15:16 ` Amit Shah
2011-04-12 15:03 ` Jes Sorensen
2011-04-12 15:13 ` Kevin Wolf
2011-04-12 15:13 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA46BFC.5090003@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).