From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Q9fHY-0005AX-Co
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 11:13:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Q9fHX-0006z6-Ji
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 11:13:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42794)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Q9fHX-0006yq-9c
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 11:13:31 -0400
Message-ID: <4DA46BFC.5090003@redhat.com>
Date: Tue, 12 Apr 2011 17:13:00 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <cover.1302617257.git.amit.shah@redhat.com>
	<1632463ee09a9df5690475f0b507757c0876fce9.1302617257.git.amit.shah@redhat.com>
	<4DA469D1.1010300@redhat.com> <4DA46C1E.1000105@redhat.com>
In-Reply-To: <4DA46C1E.1000105@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement
	'media'	subcommand
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On 04/12/11 17:13, Kevin Wolf wrote:
> Am 12.04.2011 17:03, schrieb Jes Sorensen:
>> Shouldn't you verify that you don't exceed max_len in this?
> 
> Not necessary (the buffer is always 2048 bytes), but it looks like the
> max_len parameter is unused now, so it could be removed.
> 
> Kevin

That works fine too - I just didn't like having a length and then having
it ignored completely.

Cheers,
Jes