* [Qemu-devel] [PATCH] vpc.c: Use get_option_parameter() does the search
@ 2011-04-13 9:30 Mitnick Lyu
2011-04-13 10:32 ` Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Mitnick Lyu @ 2011-04-13 9:30 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, stefanha, Mitnick Lyu
Use get_option_parameter() to instead of duplicating the loop, and use BDRV_SECTOR_SIZE to instead of 512
Signed-off-by: Mitnick Lyu <mitnick.lyu@gmail.com>
---
block/vpc.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index 7b025be..56865da 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -505,12 +505,8 @@ static int vpc_create(const char *filename, QEMUOptionParameter *options)
int ret = -EIO;
// Read out options
- while (options && options->name) {
- if (!strcmp(options->name, "size")) {
- total_sectors = options->value.n / 512;
- }
- options++;
- }
+ total_sectors = get_option_parameter(options, BLOCK_OPT_SIZE)->value.n /
+ BDRV_SECTOR_SIZE;
// Create the file
fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0644);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-13 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-13 9:30 [Qemu-devel] [PATCH] vpc.c: Use get_option_parameter() does the search Mitnick Lyu
2011-04-13 10:32 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).