* [Qemu-devel] [PATCH] libcacard: fix opposite usage of isspace
@ 2011-04-13 11:42 Alon Levy
2011-04-13 12:53 ` Hans de Goede
2011-04-18 19:18 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Alon Levy @ 2011-04-13 11:42 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Alon Levy <alevy@redhat.com>
---
libcacard/vcard_emul_nss.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index 71f2ba3..baada52 100644
--- a/libcacard/vcard_emul_nss.c
+++ b/libcacard/vcard_emul_nss.c
@@ -955,7 +955,7 @@ count_tokens(const char *str, char token, char token_end)
static const char *
strip(const char *str)
{
- for (; *str && !isspace(*str); str++) {
+ for (; *str && isspace(*str); str++) {
}
return str;
}
@@ -963,7 +963,7 @@ strip(const char *str)
static const char *
find_blank(const char *str)
{
- for (; *str && isspace(*str); str++) {
+ for (; *str && !isspace(*str); str++) {
}
return str;
}
--
1.7.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: fix opposite usage of isspace
2011-04-13 11:42 [Qemu-devel] [PATCH] libcacard: fix opposite usage of isspace Alon Levy
@ 2011-04-13 12:53 ` Hans de Goede
2011-04-18 19:18 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2011-04-13 12:53 UTC (permalink / raw)
To: qemu-devel
This is the result of an of the list discussion with
me, and I can confirm this fixes the issues I was seeing:
Tested-by: Hans de Goede <hdegoede@redhat.com>
On 04/13/2011 01:42 PM, Alon Levy wrote:
> Signed-off-by: Alon Levy<alevy@redhat.com>
> ---
> libcacard/vcard_emul_nss.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
> index 71f2ba3..baada52 100644
> --- a/libcacard/vcard_emul_nss.c
> +++ b/libcacard/vcard_emul_nss.c
> @@ -955,7 +955,7 @@ count_tokens(const char *str, char token, char token_end)
> static const char *
> strip(const char *str)
> {
> - for (; *str&& !isspace(*str); str++) {
> + for (; *str&& isspace(*str); str++) {
> }
> return str;
> }
> @@ -963,7 +963,7 @@ strip(const char *str)
> static const char *
> find_blank(const char *str)
> {
> - for (; *str&& isspace(*str); str++) {
> + for (; *str&& !isspace(*str); str++) {
> }
> return str;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: fix opposite usage of isspace
2011-04-13 11:42 [Qemu-devel] [PATCH] libcacard: fix opposite usage of isspace Alon Levy
2011-04-13 12:53 ` Hans de Goede
@ 2011-04-18 19:18 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2011-04-18 19:18 UTC (permalink / raw)
To: Alon Levy; +Cc: qemu-devel
On Wed, Apr 13, 2011 at 02:42:00PM +0300, Alon Levy wrote:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> libcacard/vcard_emul_nss.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied.
> diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
> index 71f2ba3..baada52 100644
> --- a/libcacard/vcard_emul_nss.c
> +++ b/libcacard/vcard_emul_nss.c
> @@ -955,7 +955,7 @@ count_tokens(const char *str, char token, char token_end)
> static const char *
> strip(const char *str)
> {
> - for (; *str && !isspace(*str); str++) {
> + for (; *str && isspace(*str); str++) {
> }
> return str;
> }
> @@ -963,7 +963,7 @@ strip(const char *str)
> static const char *
> find_blank(const char *str)
> {
> - for (; *str && isspace(*str); str++) {
> + for (; *str && !isspace(*str); str++) {
> }
> return str;
> }
> --
> 1.7.4.2
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-18 19:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-13 11:42 [Qemu-devel] [PATCH] libcacard: fix opposite usage of isspace Alon Levy
2011-04-13 12:53 ` Hans de Goede
2011-04-18 19:18 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).