From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42395)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1Q9zZn-0004Ui-CY
	for qemu-devel@nongnu.org; Wed, 13 Apr 2011 08:53:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1Q9zZh-0001lj-HS
	for qemu-devel@nongnu.org; Wed, 13 Apr 2011 08:53:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59523)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1Q9zZh-0001lE-9C
	for qemu-devel@nongnu.org; Wed, 13 Apr 2011 08:53:37 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3DCra4I010774
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 13 Apr 2011 08:53:36 -0400
Received: from shalem.localdomain (vpn1-5-68.ams2.redhat.com [10.36.5.68])
	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id p3DCrYkU017848
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO)
	for <qemu-devel@nongnu.org>; Wed, 13 Apr 2011 08:53:35 -0400
Message-ID: <4DA59CD8.7040206@redhat.com>
Date: Wed, 13 Apr 2011 14:53:44 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1302694920-8111-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1302694920-8111-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libcacard: fix opposite usage of isspace
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is the result of an of the list discussion with
me, and I can confirm this fixes the issues I was seeing:

Tested-by: Hans de Goede <hdegoede@redhat.com>

On 04/13/2011 01:42 PM, Alon Levy wrote:
> Signed-off-by: Alon Levy<alevy@redhat.com>
> ---
>   libcacard/vcard_emul_nss.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
> index 71f2ba3..baada52 100644
> --- a/libcacard/vcard_emul_nss.c
> +++ b/libcacard/vcard_emul_nss.c
> @@ -955,7 +955,7 @@ count_tokens(const char *str, char token, char token_end)
>   static const char *
>   strip(const char *str)
>   {
> -    for (; *str&&  !isspace(*str); str++) {
> +    for (; *str&&  isspace(*str); str++) {
>       }
>       return str;
>   }
> @@ -963,7 +963,7 @@ strip(const char *str)
>   static const char *
>   find_blank(const char *str)
>   {
> -    for (; *str&&  isspace(*str); str++) {
> +    for (; *str&&  !isspace(*str); str++) {
>       }
>       return str;
>   }