From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59637)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Q9zxZ-00031A-EW
	for qemu-devel@nongnu.org; Wed, 13 Apr 2011 09:18:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Q9zxP-0000WE-Tm
	for qemu-devel@nongnu.org; Wed, 13 Apr 2011 09:18:17 -0400
Received: from e4.ny.us.ibm.com ([32.97.182.144]:55642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Q9zxP-0000Uu-Q8
	for qemu-devel@nongnu.org; Wed, 13 Apr 2011 09:18:07 -0400
Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56])
	by e4.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p3DCw1CJ024249
	for <qemu-devel@nongnu.org>; Wed, 13 Apr 2011 08:58:01 -0400
Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 24F7D38C8038
	for <qemu-devel@nongnu.org>; Wed, 13 Apr 2011 09:17:54 -0400 (EDT)
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p3DDI3B5408450
	for <qemu-devel@nongnu.org>; Wed, 13 Apr 2011 09:18:03 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p3DDI3Rh022853
	for <qemu-devel@nongnu.org>; Wed, 13 Apr 2011 09:18:03 -0400
Message-ID: <4DA5A289.1080705@us.ibm.com>
Date: Wed, 13 Apr 2011 08:18:01 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1302698625-26136-1-git-send-email-aliguori@us.ibm.com>
	<BANLkTik2vH-9c53OD+p5dMgT1H+fa7nb9w@mail.gmail.com>
In-Reply-To: <BANLkTik2vH-9c53OD+p5dMgT1H+fa7nb9w@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] lm32: fix build breakage due to
 uninitialized variable 'r'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Edgar E Igleasias <edgar.iglesias@gmail.com>, Michael Walle <michael@walle.cc>, qemu-devel@nongnu.org

On 04/13/2011 08:04 AM, Stefan Hajnoczi wrote:
> On Wed, Apr 13, 2011 at 1:43 PM, Anthony Liguori<aliguori@us.ibm.com>  wrote:
>> diff --git a/roms/seabios b/roms/seabios
>> index cc97564..06d0bdd 160000
>> --- a/roms/seabios
>> +++ b/roms/seabios
>> @@ -1 +1 @@
>> -Subproject commit cc975646af69f279396d4d5e1379ac6af80ee637
>> +Subproject commit 06d0bdd9e2e20377b3180e4986b14c8549b393e4
> This doesn't look intentional.

!~@#!@#!@#

> I've had the same problem when using git commit -a.  Any suggestions
> to avoid adding these submodule commits by mistake?

I've been meaning to just look at fixing git submodule.  The problem is 
that when you move between branches, the submodule doesn't get updated 
correctly.

Regards,

Anthony Liguori

> Stefan