From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAEoG-0002rD-Ix for qemu-devel@nongnu.org; Thu, 14 Apr 2011 01:09:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QAEoF-0007NB-8d for qemu-devel@nongnu.org; Thu, 14 Apr 2011 01:09:40 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:64105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAEoE-0007Mx-OY for qemu-devel@nongnu.org; Thu, 14 Apr 2011 01:09:39 -0400 Message-ID: <4DA6818D.6@mail.berlios.de> Date: Thu, 14 Apr 2011 07:09:33 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1301744191-16255-1-git-send-email-weil@mail.berlios.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix conversions from pointer to tcg_target_long List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: TeLeMan Cc: Blue Swirl , QEMU Developers Am 14.04.2011 03:42, schrieb TeLeMan: > On Sat, Apr 2, 2011 at 19:36, Stefan Weil wrote: >> tcg_gen_exit_tb takes a parameter of type tcg_target_long, >> so the type casts of pointer to long should be replaced by >> type casts of pointer to tcg_target_long (suggested by Blue Swirl). >> >> These changes are needed for build environments where >> sizeof(long) != sizeof(void *), especially for w64. > There are many "(long)tb" in exec.c and the types of tb_next in > TranslationBlock, tc_ptr in tb_find_pc(), searched_pc etc. are > "unsigned long". So more patches for w64 are needed. Yes, I am very aware of this fact. This is the third effort to get QEMU code which is w64 clean. The first two were large patches which were difficult to review. Now I send small patches which will finally achieve the same goal. Sometimes these small patches seem to be unrelated to w64 (like a recent patch which removes a parameter). I think that increasing portability of software has positive effects for all targets, not only the new one. That's why I do this although I don't use w64.