From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48004)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QAI13-0007X1-7v
	for qemu-devel@nongnu.org; Thu, 14 Apr 2011 04:35:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QAI12-0005TM-6s
	for qemu-devel@nongnu.org; Thu, 14 Apr 2011 04:35:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61029)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QAI11-0005TB-Si
	for qemu-devel@nongnu.org; Thu, 14 Apr 2011 04:35:04 -0400
Message-ID: <4DA6B246.4080302@redhat.com>
Date: Thu, 14 Apr 2011 10:37:26 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <BANLkTikWG=GvCMnY6daq4VWv2wnvJwZUDw@mail.gmail.com>	<BANLkTi=-x2AgNnQ8t9H=kaAT45Az3m782w@mail.gmail.com>	<BANLkTikLnE0g=9rkkLw3Pk+UPo5HSYxCUg@mail.gmail.com>	<20110411083304.GB22987@stefanha-thinkpad.localdomain>
	<BANLkTimVJb4DkFmKvRhmhAAVZy2t=46N0Q@mail.gmail.com>
In-Reply-To: <BANLkTimVJb4DkFmKvRhmhAAVZy2t=46N0Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Question about total_sectors in block/vpc.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lyu Mitnick <mitnick.lyu@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

Am 13.04.2011 22:59, schrieb Lyu Mitnick:
> Hello Stefan,
> 
> I have a question about get_option_parameter(). I am wondering whether 
> get_option_parameter  is suitable to use instead of doing the search by
> myself 
> in the case like following:
> 
> /* Read out options */
>     while (options && options->name) {
>         if (!strcmp(options->name, BLOCK_OPT_SIZE)) {
>             // do something
>         } else if (!strcmp(options->name, BLOCK_OPT_CLUSTER_SIZE)) {
>            // do something
>         }
>         options++;
>     }

Yes, I think it is, though you need to check whether the option has been
set in order to allow use default values.

Kevin